2036153 - WebSerial requestPort() does not correctly filter on bluetoothServiceClassId

Status: RESOLVED FIXED

(Core :: DOM: Web Serial, defect, P2)

Description

[Greg Stoll :gstoll]

ApplyPortFilters() does the correct thing, but we never set the bluetoothServiceClassId on the IPCSerialPortInfo that the SerialPlatformService's return.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:cmartin, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Greg Stoll :gstoll]

Attachment: Bug 2036153 part 1 - add bluetooth service class ID information to WebSerial interfaces r=cmartin!

This is the non-platform-specific parts of this change to allow filtering
based on bluetooth service class ID.

Comment 3

[Greg Stoll :gstoll]

Attachment: Bug 2036153 part 2 - Windows bluetooth service class ID implementation for WebSerial r=#win-reviewers!

Verified on my machine that ExtractBluetoothServiceClassId() works with
real hardware.

Comment 4

[Greg Stoll :gstoll]

Attachment: Bug 2036153 part 3 - Mac/Linux bluetooth service class ID implementation for WebSerial r=#mac-reviewers!

Verified on my Mac that LookupMacBluetoothServiceClassId() works with
real hardware. Supporting this on Linux would require (I think) adding
the bluez library, which I don't think is worth it right now.

Comment 5

[Greg Stoll :gstoll]

Attachment: Bug 2036153 part 4 - Bluetooth WebSerial tests r=cmartin!

Comment 6

[BugBot [:suhaib / :marco]]

There are some r+ patches which didn't land and no activity in this bug for 1 week.
:gstoll, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 7

[Greg Stoll :gstoll]

I was hoping :haik could take a look at some of the comments on D303427 since he's set up to debug on Mac - ni? to him for that. (:haik - if that's not convenient, let me know and I can bug someone else :-) )

Comment 8

[Haik Aftandilian [:haik]]

(In reply to Greg Stoll :gstoll from comment #7)

I was hoping :haik could take a look at some of the comments on D303427 since he's set up to debug on Mac - ni? to him for that. (:haik - if that's not convenient, let me know and I can bug someone else :-) )

Responded on phabricator.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d6c462e584c3
https://hg.mozilla.org/integration/autoland/rev/46418477a125
part 1 - add bluetooth service class ID information to WebSerial interfaces r=cmartin,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/0db5ae3bf9be
https://hg.mozilla.org/integration/autoland/rev/630b9cc5c4da
part 2 - Windows bluetooth service class ID implementation for WebSerial r=win-reviewers,handyman
https://github.com/mozilla-firefox/firefox/commit/f6bb09e99a3c
https://hg.mozilla.org/integration/autoland/rev/7d2569d20777
part 3 - Mac/Linux bluetooth service class ID implementation for WebSerial r=mac-reviewers,spohl
https://github.com/mozilla-firefox/firefox/commit/7ec54bd2dd1f
https://hg.mozilla.org/integration/autoland/rev/04f886ce6b1c
part 4 - Bluetooth WebSerial tests r=cmartin

Comment 10

[rperta]

https://hg.mozilla.org/mozilla-central/rev/46418477a125
https://hg.mozilla.org/mozilla-central/rev/630b9cc5c4da
https://hg.mozilla.org/mozilla-central/rev/7d2569d20777
https://hg.mozilla.org/mozilla-central/rev/04f886ce6b1c