2036199 - Breakpad build failed on Windows using VS2026 due to removal of stdext

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[JIANG Zhirui]

Steps to reproduce:

Clone and build Firefox/Thunderbird as instructed by the official documentation.

Actual results:

40:37.85 E E:/source/3rdp/thunderbird-src/toolkit/crashreporter/breakpad-client/windows/crash_generation/minidump_generator.cc(180,21): error: no member named 'checked_array_iterator' in namespace 'stdext'
40:37.85 E   180 |             stdext::checked_array_iterator<AVRF_HANDLE_OPERATION*>(
40:37.86 E       |             ~~~~~~~~^
40:37.86 E E:/source/3rdp/thunderbird-src/toolkit/crashreporter/breakpad-client/windows/crash_generation/minidump_generator.cc(180,44): error: unexpected type name 'AVRF_HANDLE_OPERATION': expected expression
40:37.86 E   180 |             stdext::checked_array_iterator<AVRF_HANDLE_OPERATION*>(
40:37.86 E       |                                            ^
40:37.87 E E:/source/3rdp/thunderbird-src/toolkit/crashreporter/breakpad-client/windows/crash_generation/minidump_generator.cc(180,66): error: expected expression
40:37.87 E   180 |             stdext::checked_array_iterator<AVRF_HANDLE_OPERATION*>(
40:37.87 E       |
  ^
40:37.88 E mozmake[4]: *** [E:/source/3rdp/thunderbird-src/config/rules.mk:666: minidump_generator.obj] Error 1
40:37.90 E mozmake[4]: *** Waiting for unfinished jobs....
40:38.24 toolkit/system/windowsproxy
40:39.88 E mozmake[3]: *** [E:/source/3rdp/thunderbird-src/config/recurse.mk:72: toolkit/crashreporter/breakpad-windows-libxul/target-objects] Error 2
40:39.88 E mozmake[3]: *** Waiting for unfinished jobs....
40:48.79 W 4 warnings generated.
40:59.79 E mozmake[2]: *** [E:/source/3rdp/thunderbird-src/config/recurse.mk:34: compile] Error 2
40:59.79 E mozmake[1]: *** [E:/source/3rdp/thunderbird-src/config/rules.mk:357: default] Error 2
40:59.79 E mozmake: *** [client.mk:58: build] Error 2
40:59.90 W 419 compiler warnings present.

Expected results:

The build successfully with the crash reporter enabled.

A patch will be submitted.

Comment 1

[JIANG Zhirui]

Related upstream bug report and patches (not reviewed yet):

• https://issues.chromium.org/issues/508301688
• https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7808825

Comment 2

[JIANG Zhirui]

Attachment: Bug 2036199 - Remove the usage of stdext in Breakpad Windows clients; r?gsvelto

stdext::checked_array_iterator is deprecated and made unavailable on
recent MSVC release, including VS2026 Insider.

This commit modernized the serialization of minidump data in
HandleTraceData::CollectHandleData.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b4a870554f9c
https://hg.mozilla.org/integration/autoland/rev/2055d15fbab0
Remove the usage of stdext in Breakpad Windows clients; r=gsvelto

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/2055d15fbab0