2036275 - [wpt-sync] Sync PR 59551 - [line-clamp] Rename keywords for `continue` and `block-ellipsis`

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 59551 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59551
Details from upstream follow.

Andreu Botella <[e-mail]> wrote:

[line-clamp] Rename keywords for continue and block-ellipsis

In https://github.com/w3c/csswg-drafts/issues/13670, the CSSWG
resolved to rename some of the keywords for the continue and
block-ellipsis. This CL implements this.

That issue also resolved to change the max-lines property to support
clamping by both lines and height, but that will be left for a
follow-up CL.

Bug: 40336192
Change-Id: I98dbb3c3a9b4fd4225ee15ae4cd42210ff7066ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7798860
Reviewed-by: Ian Kilpatrick \<[e-mail]>
Commit-Queue: Andreu Botella \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1622659}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=96ef1cff99d0bcf4c50ddb660b0a2416a3f94fa2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 715 tests

Status Summary

Firefox

OK : 6[GitHub] 183[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 32[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 751[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 922[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 960[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 961[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL : 31[GitHub] 304[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 583[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 584[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 620[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
TIMEOUT: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
ERROR : 1
NOTRUN : 1

Chrome

OK : 6
PASS : 46
FAIL : 17

Safari

OK : 6
PASS : 38
FAIL : 25

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-overflow/inheritance.html [wpt.fyi]
  • Property max-lines has initial value none: FAIL linked bug:Bug 1985010
  • Property max-lines does not inherit: FAIL linked bug:Bug 1985010
• /css/css-overflow/parsing/line-clamp-valid.html [wpt.fyi]
  • e.style['line-clamp'] = "none" should set the property value: FAIL linked bug:Bug 1985010
  • e.style['line-clamp'] = "1" should set the property value: FAIL linked bug:Bug 1985010
  • e.style['line-clamp'] = "6" should set the property value: FAIL linked bug:Bug 1985010

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/295a2937a4b0
https://hg.mozilla.org/integration/autoland/rev/26be08cf928c
[wpt PR 59551] - [line-clamp] Rename keywords for `continue` and `block-ellipsis`, a=testonly
https://github.com/mozilla-firefox/firefox/commit/a554e25b8e62
https://hg.mozilla.org/integration/autoland/rev/e6fd6e5d4594
[wpt PR 59551] - Update wpt metadata, a=testonly

Comment 4

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/26be08cf928c
https://hg.mozilla.org/mozilla-central/rev/e6fd6e5d4594