2036320 - [wpt-sync] Sync PR 59578 - Prevent eager simplification of math nodes involving layout

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 59578 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59578
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

Prevent eager simplification of math nodes involving layout

This prevents math operations from being eagerly simplified when they
depend on layout information (like percentages that resolve against
container size), allowing them to be correctly deferred.

Fixed: 505034822
Change-Id: I1cca43c6d40c7a4c7941b65c1e6c7ac089dc41c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7797166
Commit-Queue: Daniil Sakhapov \<[e-mail]>
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1623102}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=50f0ad53c782e52240a877faf7337c4dee1fd24e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 462 tests

Status Summary

Firefox

OK : 1[GitHub] 245[Gecko-linux2404-64-debug] 246[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 3[GitHub] 20[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 5304[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 5444[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 5455[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
FAIL: 34[GitHub] 4373[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 4416[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 4429[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
PASS: 34
FAIL: 3

Safari

OK : 1
PASS: 33
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-values/typed_arithmetic.html [wpt.fyi]
  • min(1em, 110px / 10px * 1px) should be used-value-equivalent to 10px: FAIL linked bug:Bug 1973257
  • max(10px, 110px / 10px * 1px) should be used-value-equivalent to 11px: FAIL linked bug:Bug 1973257
  • max(1em + 2px, 110px / 10px * 1px) should be used-value-equivalent to 12px: FAIL linked bug:Bug 1973257
  • max(1em + 2%, 110px / 10px * 1px) should be used-value-equivalent to 12px: FAIL linked bug:Bug 1973257
  • clamp(110px / 10px * 1px, 1em + 200%, 200% * 1% / 1em) should be used-value-equivalent to 20px: FAIL linked bug:Bug 1973257
  • calc(3 + sign(10px / 1rem - sign(1em + 1px))) should be used-value-equivalent to 3: FAIL linked bug:Bug 1973257
  • calc(10em / 1em) should be used-value-equivalent to 10: FAIL linked bug:Bug 1973257
  • calc(10em / 1rem) should be used-value-equivalent to 10: FAIL linked bug:Bug 1973257
  • calc(10em / 1px) should be used-value-equivalent to 100: FAIL linked bug:Bug 1973257
  • calc(1px / 10em * NaN) should be used-value-equivalent to 0: FAIL linked bug:Bug 1973257
  • calc(1% * 100% / 10%) should be used-value-equivalent to 10%: FAIL linked bug:Bug 1991144
  • calc(10% / 10%) should be used-value-equivalent to 1: FAIL linked bug:Bug 1991144
  • calc((10% * 1%) / 1px) should be used-value-equivalent to 10px: FAIL linked bug:Bug 1991144
  • calc(1px * 2deg / 1deg) should be used-value-equivalent to 2px: FAIL linked bug:Bug 1991144
  • calc(1px * 3deg / 1deg / 1px) should be used-value-equivalent to 3: FAIL linked bug:Bug 1991144
  • calc(1px * pow(50% / 1px, 1)) should be used-value-equivalent to 50px: FAIL
  • Property width value 'calc(1px * 10em / 0em)': FAIL linked bug:Bug 1973257
  • Property width value 'calc(1px / 1px * 10em * infinity)': FAIL linked bug:Bug 1973257
  • Property margin-left value 'calc(1px * 10em / -0em)': FAIL linked bug:Bug 1973257
  • Property z-index value 'calc(10em / 0em)': FAIL linked bug:Bug 1973257
  • sign(-0em / 1px) should be used-value-equivalent to 0: FAIL linked bug:Bug 1973257
  • clamp(-1, 1 / sign(-0em / 1px), 1) should be used-value-equivalent to -1: FAIL linked bug:Bug 1973257
  • sign( 0cqi / 1px) should be used-value-equivalent to 0: FAIL linked bug:Bug 1973257
  • clamp(-1, 1 / sign( 0cqi / 1px), 1) should be used-value-equivalent to 1: FAIL linked bug:Bug 1973257
  • sign(atan2(-0cap / 1px, 0em / 1px)) should be used-value-equivalent to 0: FAIL linked bug:Bug 1973257
  • clamp(-1, 1 / sign(atan2(-0cap / 1px, 0em / 1px)), 1) should be used-value-equivalent to -1: FAIL linked bug:Bug 1973257
  • sign(exp(-1vh / 0px)) should be used-value-equivalent to 0: FAIL linked bug:Bug 1973257
  • clamp(-1, 1 / sign(exp(-1vh / 0px)), 1) should be used-value-equivalent to 1: FAIL linked bug:Bug 1973257
  • calc(20cqw / 1rem) should be used-value-equivalent to 2: FAIL linked bug:Bug 1973257
  • Property animation-duration value 'calc(2s / (10s - 10s) * 1s)': FAIL linked bug:Bug 1973257
  • subtraction of angle unit: deg minus turn: FAIL linked bug:Bug 1973257

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c2c2e29e8127
https://hg.mozilla.org/integration/autoland/rev/015b48f5b07e
[wpt PR 59578] - Prevent eager simplification of math nodes involving layout, a=testonly
https://github.com/mozilla-firefox/firefox/commit/1ee219ab08fd
https://hg.mozilla.org/integration/autoland/rev/c0eb4cc4291f
[wpt PR 59578] - Update wpt metadata, a=testonly

Comment 4

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/015b48f5b07e
https://hg.mozilla.org/mozilla-central/rev/c0eb4cc4291f