Closed Bug 2036339 Opened 16 days ago Closed 9 days ago

[wpt-sync] Sync PR 59586 - [Masonry] Fix subgrid available size in subgridded axis

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 59586 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59586
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[Masonry] Fix subgrid available size in subgridded axis

When a subgrid is laid out as a child of grid-lanes, set the available
size along its subgridded axis to the parent's track size minus margins,
similar to Grid.

This also removes a TODO added by Celeste that I believe has already
been addressed.

I also noticed that in Grid, the SubgriddedItemData passed in will be
queried for in the case of subgrids, and the constraint space also pulls
the subgrid's constraint in the standalone axis so the subgridded items
are sized properly. Neither of which are done in grid lanes today. I've
added TODOs for these to be addressed in follow up changes.

There is one new test failure related to auto track sizing that will
require a 2nd pass to get the correct row size.

Bug: 343257585
Change-Id: Ia345a42d2cd2175108aad4e4ac36e8b344fe32da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7801962
Commit-Queue: Alison Maher \<almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1623539}

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 39 tests

Status Summary

Firefox

PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, GitHub] 5[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 3[GitHub] 34[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 2
FAIL: 2

Safari

PASS: 3
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/47cabd843c93
https://hg.mozilla.org/mozilla-central/rev/e661d1e0776f

Status: NEW → RESOLVED
Closed: 9 days ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.