2036365 - Slow composites when using DComp. Time spent in NtFlipObjectAddPoolBuffer and ZwFlipObjectRemoveContent

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

From https://www.reddit.com/r/firefox/comments/1t049ar/jerky_stuttery_scrolling/

Browser runs better when profiling with screenshots which disables DirectComposition.

Happens on Nvidia

Here's an excerpt of the profile: https://share.firefox.dev/4tKqxmy

DirectComposition::CDevice::CreateCompositionTexture is waiting on NtFlipObjectAddPoolBuffer
and releasing it gets stuck on ZwFlipObjectRemoveContent

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Any guesses Sotaro?

Comment 2

[Sotaro Ikeda [:sotaro]]

It's particularly bad on websites with embedded video. LinkedIn is really bad when there's a video on the page, but smooth otherwise with pictures and text. Here's an example, this blog has video in the page, and scrolling through that is slow and jerky. Smooth once the video is off the screen.

https://blog.mozilla.org/performance/2024/12/12/introducing-the-chrome-extension-for-the-firefox-profiler/

Current DCLayerTree has a mechanism to detect slow present with video overlay. But it seemed not work in this case.

Comment 3

[Sotaro Ikeda [:sotaro]]

It seems better to disable WebGL overlay if RenderDXGITextureHost::GetDCompositionTexture() becomes slow.

And going to look into if I could reproduce the problem.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)

From https://www.reddit.com/r/firefox/comments/1t049ar/jerky_stuttery_scrolling/

Browser runs better when profiling with screenshots which disables DirectComposition.

With layer compositor, DirectComposition is not disabled during taking profile with screenshot. It just disables overlays.

Comment 5

[Sotaro Ikeda [:sotaro]]

I could reproduce the problem with the following with NVIDIA GPU. I am going to look into it.

https://webglsamples.org/aquarium/aquarium.html

Comment 6

[Sotaro Ikeda [:sotaro]]

With WebGL, gl::SharedSurface is recycled in WebGLContext::PushRemoteTexture(). But TextureHost is not recycled. The TextureHost is always created in RemoteTextureOwnerClient::PushTexture(). Then RenderDXGITextureHost is always created for rendering update. Then IDCompositionTexture was always created in RenderDXGITextureHost::GetDCompositionTexture() for each update.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2008399

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 2036365 - Disable overlay of WebGL/WebGPU on Windows

Disable WebGL/WebGPU overlay until Bug 2036655 is addressed.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 2036365 - Disable overlay of WebGL/WebGPU on Windows

Disable overlay of WebGL/WebGPU until Bug 2036655 is addressed.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b188e5d5717b
https://hg.mozilla.org/integration/autoland/rev/4e435e4657ea
Disable overlay of WebGL/WebGPU on Windows r=gfx-reviewers,lsalzman

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Bad performance regression on WebGL on some platforms
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This just reverts the change from bug 2013143
• String changes made/needed?: No
• Is Android affected?: no

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 2036365 - Disable overlay of WebGL/WebGPU on Windows

Disable WebGL/WebGPU overlay until Bug 2036655 is addressed.

Original Revision: https://phabricator.services.mozilla.com/D298160

Comment 13

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Bad performance regression on WebGL on some platforms
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This just reverts the change from bug 2013143
• String changes made/needed?: No
• Is Android affected?: no

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 2036365 - Disable overlay of WebGL/WebGPU on Windows

Disable WebGL/WebGPU overlay until Bug 2036655 is addressed.

Original Revision: https://phabricator.services.mozilla.com/D298160

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4e435e4657ea

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2c3f8d5a8400
https://hg.mozilla.org/releases/mozilla-beta/rev/c6b9c0e736cf

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/695e5f76bd2d
https://hg.mozilla.org/releases/mozilla-release/rev/e7ff094e396d