2036676 - Compiling on Windows broken with --disable-necko-wifi set

Status: RESOLVED FIXED

(Toolkit :: Geolocation Provider, defect)

Description

[k4sum1]

Steps to reproduce:

Add ac_add_options --disable-necko-wifi to mozconfig and start compiling.

Actual results:

Compiling fails with nsIWifiListener.h not found.

Expected results:

Browser should compile without errors.

Comment 1

[k4sum1]

Not entirely sure where to put this part as I have no additional information box to type in, so new comment it is.

I've traced it to Bud 1900225, and specifically part 5 and part 6. The code was written with the assumption that the necko wifi scanner will always be available, and in this case it is not. For my fork, I've found this workaround for successful builds. https://github.com/Eclipse-Community/r3dfox/commit/be22ead533916ecc79419a2d50459da2b68ac6d2

I figure since it should be a supported build flag, I'd open this issue and see if it will get fixed. Affected versions include ESR 128. ESR 140, and latest 150.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, but is not confident enough to move the bug to that component.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:handyman, since you are the author of the regressor, bug 1900225, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[David Parks [:handyman]]

Attachment: Bug 2036676: Use basic GeolocationSystem implementation when NECKO_WIFI is not defined r=jjaschke!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9e104dc96f58
https://hg.mozilla.org/integration/autoland/rev/d50ebbfcb25a
Use basic GeolocationSystem implementation when NECKO_WIFI is not defined r=jjaschke

Comment 6

[k4sum1]

That's a lot simpler than I had anticipated it would be, thank you. Could you also uplift it to 140 too pls.

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d50ebbfcb25a

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1900225

Comment 9

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

I think we should probably think about removing wifi scanning than requiring wifi, is scanning wifi the only way to prompt geolocation? Can we call geolocation API instead?

Comment 10

[David Parks [:handyman]]

(In reply to Kagami Rosylight [:saschanaz] (they/them) from comment #9)

I think we should probably think about removing wifi scanning than requiring wifi, is scanning wifi the only way to prompt geolocation? Can we call geolocation API instead?

Filed bug 2040528 for this.

Comment 11

[David Parks [:handyman]]

Attachment: Bug 2036676: Use basic GeolocationSystem implementation when NECKO_WIFI is not defined

Original Revision: https://phabricator.services.mozilla.com/D300825

Comment 12

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined/Reason for urgency: Repo doesn't build with --disable-necko-wifi set
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This change only affects builds that set --disable-necko-wifi. It disables some of the Windows geolocation UX in those builds. Previously, those builds would not compile.
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/f93a726de965