2036762 - Remove the "General" pane when SRD is enabled

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Hanna Jones [:hjones]]

When SRD is enabled we should be able to remove or hide the "General" pane, since all of the preferences will have been moved to new panes. We should also look into making the "Account and sync" pane the default pane.

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 2036762 - Make Accounts and sync pane default with SRD enabled r=#recomp-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/28d8ab514160
https://hg.mozilla.org/integration/autoland/rev/e1adf1be3996
Make Accounts and sync pane default with SRD enabled r=mkennedy

Comment 3

[agoloman]

Backed out for causing mochitest failures.

• Backout link
• Push with failures
• Failure Log tr8ns
• Failure Log bc

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e1adf1be3996

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7ce3f5fc61f
https://hg.mozilla.org/integration/autoland/rev/e5426987b417
Make Accounts and sync pane default with SRD enabled r=mkennedy,translations-reviewers,nordzilla

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cca7a4bf45d1
https://hg.mozilla.org/integration/autoland/rev/07f0c98aa924
Revert "Bug 2036762 - Make Accounts and sync pane default with SRD enabled r=mkennedy,translations-reviewers,nordzilla" for causing bc failures @ browser_browser_languages_main_pane.js

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_browser_languages_main_pane.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/07f0c98aa924474ea5c33c28ad99c8f940afa4db

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_browser_languages_main_pane.js | testRemoteLocalesNotFetchedUntilLanguagesPaneShown - Uncaught exception in test - TypeError: can't access property "controlEl", preferredLanguage is null

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/012813a867fb
https://hg.mozilla.org/integration/autoland/rev/a3c7691b09df
Make Accounts and sync pane default with SRD enabled r=mkennedy,translations-reviewers,nordzilla

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a3c7691b09df