2036792 - FxA Oauth Token destruction is racy.

Status: VERIFIED FIXED

(Firefox :: IP Protection, defect)

Description

[Sebastian Streich [:sstreich]]

The changes in 2034525 allowed the option for the destroy path to be called before the /token request has concluded, this caused a flaky race situation.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2034525

Comment 2

[Sebastian Streich [:sstreich]]

Attachment: Bug 2036792 - make sure requests have concluded before desposing the token r=#ip-protection-reviewers

If we don't await the call to guardian client but instantly return the promise, the FxA token destroy request will be sent while request to guardian is mid-flight.

Comment 3

[Fred Chasen [:fchasen]]

Do you think that bug 2036612 might be related?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3efa4fcefd25
https://hg.mozilla.org/integration/autoland/rev/b4d3fe5dc9e9
make sure requests have concluded before desposing the token r=ip-protection-reviewers,fchasen,kpatenio

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b4d3fe5dc9e9

Comment 7

[Raluca Ilban [:rilban], Premium Services - VPN]

We have verified this using Firefox Nightly 152.0a1 (2026-05-05) build on Windows 11.
The VPN can e turned on. Is there something else that QA can verify here? Thank you!

Comment 8

[Sebastian Streich [:sstreich]]

Nothing else to do thanks!