Closed Bug 2036835 Opened 1 month ago Closed 1 month ago

Update View Schedule click action for the Homepage Sports Widget

Categories

(Firefox for Android :: Homepage, task)

All
Android
task

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox151 --- wontfix
firefox152 --- wontfix

People

(Reporter: moyin, Assigned: moyin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group3][world-cup-phase1] )

Attachments

(1 file, 1 obsolete file)

Implement a Firefox Search instead when the View Schedule button is clicked

Assignee: nobody → madeyemi
Depends on: 2035767
Depends on: 2036797
No longer depends on: 2035767
No longer depends on: 2036797
Blocks: 2036797
Pushed by madeyemi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/27cd23fc068f https://hg.mozilla.org/integration/autoland/rev/b4180bd64092 Update View Schedule click action for the Homepage Sports Widget r=android-reviewers,skhan
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: This patch is needed for the World Cup feature which is hidden behind a feature flag
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: - Enable the Homepage Sports Widget in Secret Settings
  • Click on the View Schedule button on the sports widget

Previous behavior

  • Opens a link to the schedule on FIFA's website

New behavior

  • Opens a Firefox Search with the World Cup Schedule query
  • Risk associated with taking this patch: low
  • Explanation of risk level: The feature is gated with a secret setting
  • String changes made/needed?: N/A
  • Is Android affected?: yes
Attachment #9583564 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Attachment #9583564 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [fxdroid][group3] → [fxdroid][group3][world-cup-phase1]

Donal, this needs to be reverted from nightly and beta both (since it got uplifted). The product now wants the fifa link back on clicking the view schedule button. Conversation below
https://mozilla.slack.com/archives/C0ARLQ43Q7Q/p1778160170323369

Flags: needinfo?(dmeehan)

Reverted from Fx151 beta as requested since an alternative patch is needed instead.

:skhan, this doesn't revert cleanly from firefox-main for Fx152 nightly.
There are merge conflicts with Bug 2036447 and Bug 2036176 in mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt

You will need to make a patch here targeting autoland that reverts https://github.com/mozilla-firefox/firefox/commit/27cd23fc068f and fixes the conflicts. Land it through the usual review and landing process.

Flags: needinfo?(dmeehan) → needinfo?(skhan)
Attachment #9583564 - Attachment is obsolete: true
Blocks: 2037957

Verified as fixed on the latest Nightly build (152.0a1 from 2026-05-07).

Clicking on the View Schedule button on the sports widget opens a Firefox Search with the World Cup Schedule query.

Tested device: Vivo X80 Lite (Android 13), Redmi Pad SE (Android 14).

Marking as verified on 152.

Will be verified on 151 after the uplift.

Flags: qe-verify+

Lorand, FYI this patch was reverted to the previous behavior and should continue to open the FIFA link instead of the World Cup Schedule query.

Bug 2037957 reverted this from firefox-main for Fx152

Status: RESOLVED → REOPENED
Flags: needinfo?(skhan)
Resolution: FIXED → ---
Target Milestone: 152 Branch → ---
Status: REOPENED → RESOLVED
Closed: 1 month ago1 month ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: