2036948 - [TOS] Update showModal to use gBrowser.selectedBrowser

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect)

Description

[Mimi Jung]

Looks like 2033243 exposed an existing issue with passing a chrome Window to showModal when it actually expects a <browser> element. Before 2033243, ownerGlobal was defined on EventTarget and since Window implements EventTarget, win.ownerGlobal reurned the window itself. With the cleanup, it was replaced with documentGlobal causing the new TOU modal to not render in the Window. We should be using win.gBrowser.selectedBrowser instead.

This was evident when enabling logs, I could see: modal displayed, waiting for user interaction but no TOU modal.

Comment 1

[Mimi Jung]

Attachment: Bug 2036948 - [TOS] - Update showModal to use gBrowser.selectedBrowser

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Do we really have zero test coverage of this codepath? This should've been caught by bug 2033191 comment 2 otherwise :(

Comment 3

[Mimi Jung]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #2)

Do we really have zero test coverage of this codepath? This should've been caught by bug 2033191 comment 2 otherwise :(

Yeah I was surprised as well, my local changes have test coverage added that I'll push up to my patch today.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c2e4ff9f9ac9
https://hg.mozilla.org/integration/autoland/rev/6c7e4caffd18
[TOS] - Update showModal to use gBrowser.selectedBrowser r=omc-reviewers,janerik,sachung

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6c7e4caffd18

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2036439