2037033 - [wpt-sync] Sync PR 59644 - Make option:disabled match inside disabled select

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 59644 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59644
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Make option:disabled match inside disabled select

Options and optgroups aren't considered disabled when they are inside a
disabled select, which is causing an issue for customizable select UA
styles where hover styles are activating when the select is disabled.

Some code still needs to consider options inside a disabled select as
enabled in order to make sure that an option becomes selected inside a
disabled select, so now the :enabled and :disabled pseudo-classes don't
match up with the internally disabled state.

Context: https://github.com/w3c/csswg-drafts/issues/13383
Spec PR: https://github.com/whatwg/html/pull/12205

Fixed: 490082172
Change-Id: I8c4dac7ee5da5e36ab205a536d36651528937df8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7624129
Reviewed-by: David Baron \<[e-mail]>
Reviewed-by: Joey Arhar \<[e-mail]>
Commit-Queue: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1624951}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0eb600040a5e339ba0e6e02e48792c4ce0264446

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 162 tests

Status Summary

Firefox

OK : 2[GitHub] 86[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 7[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 9[GitHub] 185[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 189[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 200[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 201[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 4[GitHub] 125[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 152[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 180[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 181[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 2
PASS: 10
FAIL: 3

Safari

OK : 2
PASS: 10
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /html/semantics/forms/the-select-element/customizable-select/option-disabled-optgroup.html [wpt.fyi]
  • options should check ancestor optgroup for disabled state.: FAIL

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b715df7b4934
https://hg.mozilla.org/integration/autoland/rev/97377e959341
[wpt PR 59644] - Make option:disabled match inside disabled select, a=testonly
https://github.com/mozilla-firefox/firefox/commit/fc4d59b1d8c8
https://hg.mozilla.org/integration/autoland/rev/53dee52c445b
[wpt PR 59644] - Update wpt metadata, a=testonly

Comment 4

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/97377e959341
https://hg.mozilla.org/mozilla-central/rev/53dee52c445b