2037072 - Don't show the review prompt if the continuous onboarding has not been completed

Status: VERIFIED FIXED

(Firefox for Android :: Onboarding, task)

Description

[twhite (OOO 3rd July - 10th July)]

Attachment: Screenshot_20260504_084822_Firefox.jpg

Both ratings and notifications prompts from day 2 onboarding can trigger at the same time.

Comment 1

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2037072 - Don't show the review prompt if the continuous onboarding has not been completed.

ReviewPromptMiddlewareTest are NOT updated here as this requires uplift, and ReviewPromptMiddlewareTest was updated in https://bugzilla.mozilla.org/show_bug.cgi?id=2030917 which will require a large and potentially complicated number of additional uplifts.

Comment 2

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2037072 - Don't show the review prompt if the continuous onboarding has not been completed.

ReviewPromptMiddlewareTest is not updated here because this change requires uplift. The test file was updated in https://bugzilla.mozilla.org/show_bug.cgi?id=2030917 (which added the kotlin test lib and updated a number of other test files), and including that update would require a large, potentially complicated set of additional uplifts.

Original Revision: https://phabricator.services.mozilla.com/D298531

Comment 3

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users could be spammed by dialogs during continuous onboarding, resulting in negative reviews when propmted for a review
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See bug details
• Risk associated with taking this patch: low
• Explanation of risk level: No user risk, this only affects the custom review prompt show logic - which will be delayed until the continuous onboarding is complete
• String changes made/needed?: -
• Is Android affected?: yes

Comment 4

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2037072 - Don't show the review prompt if the continuous onboarding has not been completed.

ReviewPromptMiddlewareTest is not updated here because this change requires uplift. The test file was updated in https://bugzilla.mozilla.org/show_bug.cgi?id=2030917 (which added the kotlin test lib and updated a number of other test files), and including that update would require a large, potentially complicated set of additional uplifts.

Original Revision: https://phabricator.services.mozilla.com/D298531

Comment 5

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Users could be spammed by dialogs during continuous onboarding, resulting in negative reviews when propmted for a review
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See bug details
• Risk associated with taking this patch: low
• Explanation of risk level: No user risk, this only affects the custom review prompt show logic - which will be delayed until the continuous onboarding is complete
• String changes made/needed?: -
• Is Android affected?: yes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cdc15e38376b
https://hg.mozilla.org/integration/autoland/rev/9892d87df727
Don't show the review prompt if the continuous onboarding has not been completed. r=android-reviewers,rebecatudor273

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9892d87df727

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/89753ba2fb18
https://hg.mozilla.org/releases/mozilla-beta/rev/65cf19eb13f4

Comment 9

[Mira Lobontiu (Android QA)]

Verified on the latest Firefox for Android Nightly 152.0a1 from 5/7, and on Beta 151.0b7, using a Samsung Galaxy Tab S9 Ultra (Android 16), and on Google Pixel 6 (Android 17).
The review prompt is not displayed while the continuous onboarding cards are displayed.

However, the review prompt was not displayed at all after this scenarios:

1. Day 1: accept ToU, set as default.
2. Day 2: don't allow Notifications.
3. Day 7: allow Notifications.
4. Browse a few pages.
5. Day 14: don't sign in.

OR:

1. Day 1: accept ToU, set as default.
2. Day 2: allow Notifications & browse a few pages.
3. Day 7: sign in.

Tom, can I trigger the review prompt with a different scenario?

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/07d3e2e613a1
https://hg.mozilla.org/releases/mozilla-release/rev/191aab98113f

Comment 11

[twhite (OOO 3rd July - 10th July)]

Mira, thanks for the heads up! The current logic is:

• User has not been prompted in the last 4 months
• Firefox is set as the default browser
• Firefox has been opened at least 5 times

Does that align with the above testing?

Comment 12

[Mira Lobontiu (Android QA)]

Hi Tom,
I've retested with the current logic, and the review prompt was displayed correctly, after the continuous onboarding was finished. Tested on Firefox for Android Beta 151.0b9, and on Firefox for Android 150.0.3.

Tested with a Samsung Galaxy S24 (Android 16).