2037159 - Revert "Perform search when users enters text in urlbar and selects search engine"

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Dale Harvey (:daleharvey)]

Accessibility team have voiced concerns over this change in behaviour and recommended reverting it.

Comment 1

[Dale Harvey (:daleharvey)]

(https://bugzilla.mozilla.org/show_bug.cgi?id=2026387)

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 2037159 - Enter search mode when selecting engine from unified search panel. r=dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e6abef4ec437
https://hg.mozilla.org/integration/autoland/rev/ff3809e13d07
Enter search mode when selecting engine from unified search panel. r=search-reviewers,urlbar-reviewers,adw,jteow

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/ff3809e13d07

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: Bug 2037159 - Enter search mode when selecting engine from unified search panel.

Original Revision: https://phabricator.services.mozilla.com/D298668

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: A change in behaviour was introduced that the accessibility team asked to be reverted. We would really like to avoid exposing the users to the change in behaviour both to avoid being exposed to the regression and also to avoid users learning a new behaviour that changes on the next release
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Pick an engine from the unified search panel, searchmode should be entered
• Risk associated with taking this patch: low
• Explanation of risk level: Although it is late in the release cycle it is a relatively simple patch
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2b4696d44a56
https://hg.mozilla.org/releases/mozilla-beta/rev/4a8bf52096fe

Comment 8

[Petruta Horea [:phorea]]

Verified the search is no longer performed when choosing a search engine, search mode is opened instead, using Firefox 151 beta 9 and latest Nightly 152.0a1 under Win 11, macOS 15 and Ubuntu 24.

Comment 9

[Florin Bilt]

(In reply to pstanciu from comment #4)

https://hg.mozilla.org/mozilla-central/rev/ff3809e13d07

Perfherder has detected a browsertime performance change from push ff3809e13d07e1ea35bd587145ff2b52c33ec81d.

No action is required from the author; this comment is provided for informational purposes only.

Improvements	Test	Platform	Options	Absolute values [old vs new]	Performance Profiles
6%	speedometer3 TodoMVC-WebComponents/total (doc)	linux2404-64-nightlyasrelease	fission webrender	41.40 ms -> 38.71 ms	Before/After
6%	speedometer3 TodoMVC-WebComponents/total (doc)	linux2404-64-nightlyasrelease	fission webrender	41.49 ms -> 38.88 ms	Before/After
6%	speedometer3 TodoMVC-Backbone/total (doc)	linux2404-64-nightlyasrelease	fission webrender	68.87 ms -> 65.05 ms	Before/After
5%	speedometer3 TodoMVC-React-Complex-DOM/total (doc)	linux2404-64-nightlyasrelease	fission webrender	86.71 ms -> 82.70 ms	Before/After
4%	speedometer3 Charts-observable-plot/total (doc)	linux2404-64-nightlyasrelease	fission webrender	89.56 ms -> 85.58 ms	Before/After
...	...	...	...	...	...
3%	speedometer3 NewsSite-Next/total (doc)	linux2404-64-nightlyasrelease	fission webrender	218.03 ms -> 211.88 ms	Before/After

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.