Closed Bug 2037247 Opened 6 months ago Closed 6 months ago

Create a SportsCardPager with a 3-dot overflow menu

Categories

(Firefox for Android :: Homepage, task)

Product:
Firefox for Android
Component:
Homepage
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox151 --- fixed
firefox152 --- fixed

People

(Reporter: skhan, Assigned: moyin)

References

Details

(Whiteboard: [fxdroid][group3][world-cup-phase2])

Attachments

(20 external files)

Design : https://www.figma.com/design/Lmyd7U4KRQAsrhwrXQZ4mL/Mobile-Worldcup?node-id=3963-111606&m=dev
Goals: Add

  • Change team → opens country selector bottom sheet
  • Get custom wallpaper → opens wallpaper section in Settings
  • Remove → removes widget and disables it in Settings
Summary: Add 3-dot overflow menu on the widget → Create a SportsCardPager with a 3-dot overflow menu
Assignee: nobody → madeyemi
Whiteboard: [fxdroid][group3]
Whiteboard: [fxdroid][group3] → [fxdroid][group3][world-cup-phase2]
Pushed by madeyemi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/73ca95acc0f3 https://hg.mozilla.org/integration/autoland/rev/e59d7a076197 Part 1: Create a new parent component for the SportsWidget r=android-reviewers,skhan https://github.com/mozilla-firefox/firefox/commit/59f983820e71 https://hg.mozilla.org/integration/autoland/rev/7ff39fadde79 Part 2: Implement the SportsCardPager and menu r=android-reviewers,android-l10n-reviewers,flod,skhan https://github.com/mozilla-firefox/firefox/commit/0f8bb9129205 https://hg.mozilla.org/integration/autoland/rev/f73a5a57838e Part 3: Implement the oneWeekToWorldCup state r=android-reviewers,pollymce https://github.com/mozilla-firefox/firefox/commit/3fdf75d320f2 https://hg.mozilla.org/integration/autoland/rev/8e6620d01e53 Part 4: Update and clean up Sports composables r=android-reviewers,pollymce https://github.com/mozilla-firefox/firefox/commit/f22a3719c8f1 https://hg.mozilla.org/integration/autoland/rev/3fe77d20fb5c Part 5: Implement the Get custom wallpaper menu item action r=android-reviewers,pollymce
Attachment #9591748 - Attachment description: WIP: Bug 2037247 - Part 5: Implement the Get custom wallpaper menu item action → Bug 2037247 - Part 5: Implement the Get custom wallpaper menu item action
Attachment #9591747 - Attachment description: WIP: Bug 2037247 - Part 4: Update and clean up Sports composables → Bug 2037247 - Part 4: Update and clean up Sports composables
Attachment #9591746 - Attachment description: WIP: Bug 2037247 - Part 3: Implement the oneWeekToWorldCup state → Bug 2037247 - Part 3: Implement the oneWeekToWorldCup state
Attachment #9591745 - Attachment description: WIP: Bug 2037247 - Part 2: Implement the SportsCardPager and menu → Bug 2037247 - Part 2: Implement the SportsCardPager and menu
Attachment #9591744 - Attachment description: WIP: Bug 2037247 - Part 1: Create a new parent component for the SportsWidget → Bug 2037247 - Part 1: Create a new parent component for the SportsWidget
Attachment #9591748 - Flags: approval-mozilla-release+
Attachment #9591747 - Flags: approval-mozilla-release+
Attachment #9591746 - Flags: approval-mozilla-release+
Attachment #9591745 - Flags: approval-mozilla-release+
Attachment #9591744 - Flags: approval-mozilla-release+

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: