2037356 - Enable dom.pointer-lock.native-lock.enabled by default on macOS

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Edgar Chen [:edgar]]

Now that bug 2036482 is in Nightly, I tested it with https://codepen.io/editor/edgarchen-the-decoder/pen/019df226-8436-7e1f-b91f-92d78779d46b
and everything works well on macOS. Let’s turn the pref on by default then.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 2037356 - Enable dom.pointer-lock.native-lock.enabled by default on macOS; r?smaug

Comment 2

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar] from comment #0)

Now that bug 2036482 is in Nightly, I tested it with https://codepen.io/editor/edgarchen-the-decoder/pen/019df226-8436-7e1f-b91f-92d78779d46b
and everything works well on macOS. Let’s turn the pref on by default then.

Err, just found bug 2037367.

Comment 3

[Edgar Chen [:edgar]]

Attachment: WIP: Bug 2037356 - [Cocoa] Report buttons correctly while pointer is locked with native API;

Comment 4

[Edgar Chen [:edgar]]

Attachment: Bug 2037356 - [Cocoa] Report buttons correctly while pointer is locked with native API;

Comment 5

[Phabricator Automation]

Comment on attachment 9583651 [details]
Bug 2037356 - [Cocoa] Report buttons correctly while pointer is locked with native API;

Revision D298803 was moved to bug 2037367. Setting attachment 9583651 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/098eb4c91a73
https://hg.mozilla.org/integration/autoland/rev/27a49212084c
Enable dom.pointer-lock.native-lock.enabled by default on macOS; r=smaug

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/27a49212084c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something we should call out in the Fx152 relnotes? Please add a relnote-firefox? nomination if yes.

Comment 9

[Edgar Chen [:edgar]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)

Is this something we should call out in the Fx152 relnotes? Please add a relnote-firefox? nomination if yes.

No, there are no user-facing changes, so this does not need to be called out in the release notes, IMO.