Closed Bug 2037599 Opened 6 months ago Closed 5 months ago

Enable dom.script_loader.external_scripts.speculate_link_preload.enabled

Categories

(Core :: Performance: Navigation, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
153 Branch
Performance Impact none
Tracking Status
firefox153 --- fixed

People

(Reporter: jrmuizel, Assigned: denispal)

References

Details

(Keywords: webcompat:platform-bug)

User Story

user-impact-score:3900

Attachments

(2 external files)

This matches what Chrome does, seems reasonable, and fixes a script ordering issue on aol.com

Blocks: 2030614
User Story: (updated)

This has been introduced in bug 1606652 in 2020 by denispal. Denis, do you have any concern enabling it today?

Depends on: 1606652
Flags: needinfo?(dpalmeiro)

I don't think there is any issue. Running some tests now.

Flags: needinfo?(dpalmeiro)

(Given it has been disabled everywhere, probably we want to test it on nightly/beta for a while)

Assignee: nobody → dpalmeiro
Status: NEW → ASSIGNED
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/005f0c88dfe4 https://hg.mozilla.org/integration/autoland/rev/5c0e7fb7789d Revert "Bug 2037599: Enable speculative parsing of link preload scripts. r=smaug" for causing awsy tp6 failures at awsy/test_memory

Backed out for causing awsy tp6 failures at awsy/test_memory
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-ERROR | awsy/test_memory_usage.py TestMemoryUsage.test_open_tabs | marionette_driver.errors.TimeoutException: Navigation timed out after 300000 ms

Flags: needinfo?(dpalmeiro)
Pushed by nfay@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2bd20c6194da https://hg.mozilla.org/mozilla-central/rev/cdabc42428fa Revert "Bug 2037599: Enable speculative parsing of link preload scripts. r=smaug" for causing awsy tp6 failures at awsy/test_memory
User Story: (updated)
Performance Impact: --- → none

This fixes a race condition in the nytimes awsy test when speculation for link preload scripts is enabled. The same problem exists for async speculation. The element is created while the link preload script is still compiling. This puts the script in the mLoadingAsyncScripts list (which is correct). Then when the script is finished compiling, it calls ProcessOffThreadRequest which sets the script to ready and then checks if the script is already in a list. Since this script is already in the loading list, it is not processed and the script is left in the mLoadingAsyncScripts forever. The fix is to move the script to the mLoadedAsyncScripts list if this happens so it can be processed later in ProcessPendingRequests.

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Regressions: 2043955
Regressions: 2045284
Flags: needinfo?(dpalmeiro)
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: