Enable dom.script_loader.external_scripts.speculate_link_preload.enabled
Categories
(Core :: Performance: Navigation, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: denispal)
References
Details
(Keywords: webcompat:platform-bug)
User Story
user-impact-score:3900
Attachments
(2 external files)
This matches what Chrome does, seems reasonable, and fixes a script ordering issue on aol.com
Updated•6 months ago
|
Updated•6 months ago
|
Comment 1•6 months ago
|
||
This has been introduced in bug 1606652 in 2020 by denispal. Denis, do you have any concern enabling it today?
| Assignee | ||
Comment 2•6 months ago
|
||
I don't think there is any issue. Running some tests now.
Comment 3•6 months ago
|
||
(Given it has been disabled everywhere, probably we want to test it on nightly/beta for a while)
| Assignee | ||
Comment 4•6 months ago
|
||
Updated•6 months ago
|
Comment 7•6 months ago
|
||
Backed out for causing awsy tp6 failures at awsy/test_memory
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-ERROR | awsy/test_memory_usage.py TestMemoryUsage.test_open_tabs | marionette_driver.errors.TimeoutException: Navigation timed out after 300000 ms
Comment 9•6 months ago
|
||
Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/cdabc42428fa68fd62d2c05537373e8ae409a194
Updated•6 months ago
|
Updated•5 months ago
|
| Assignee | ||
Comment 10•5 months ago
|
||
This fixes a race condition in the nytimes awsy test when speculation for link preload scripts is enabled. The same problem exists for async speculation. The element is created while the link preload script is still compiling. This puts the script in the mLoadingAsyncScripts list (which is correct). Then when the script is finished compiling, it calls ProcessOffThreadRequest which sets the script to ready and then checks if the script is already in a list. Since this script is already in the loading list, it is not processed and the script is left in the mLoadingAsyncScripts forever. The fix is to move the script to the mLoadedAsyncScripts list if this happens so it can be processed later in ProcessPendingRequests.
Comment 11•5 months ago
|
||
Comment 12•5 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/87c6484b1089
https://hg.mozilla.org/mozilla-central/rev/33e6b973b906
| Assignee | ||
Updated•5 months ago
|
Updated•5 months ago
|
Description
•