2037632 - Make `auto` default for Element.scrollIntoView

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 2037632 - Make `auto` as the default ScrollIntoViewOptions. r?#layout-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/689f692d343c
https://hg.mozilla.org/integration/autoland/rev/674ab272d8ff
Make `auto` as the default ScrollIntoViewOptions. r=layout-reviewers,webidl,emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/74ba4ed0d4e2
https://hg.mozilla.org/integration/autoland/rev/ec30eb9373c0
Revert "Bug 2037632 - Make `auto` as the default ScrollIntoViewOptions. r=layout-reviewers,webidl,emilio" for causing wr failures on scrollbar-gutter-scroll-into-view.html.

Comment 4

[Iulian Moraru]

Revert for causing wr failures on scrollbar-gutter-scroll-into-view.html.

• Push with failures

• Failure log

• Backout link

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 2037632 - Resolve scrollIntoView "auto" against the target's writing mode to fix scrollbar-gutter-scroll-into-view regression. r?#layout-reviewers

The previous change collapsed the auto fallback to a fixed pair (Start for
the physical vertical axis, Nearest for the physical horizontal axis), which
matches the spec defaults (block: start, inline: nearest) only in horizontal
writing modes. In vertical writing modes the physical-to-logical mapping is
reversed, and in vertical-rl the block-axis default is "end" rather than
"start".

Pass the target's writing mode through ScrollToShowRect into
GetApplicableWhereToScroll so it can resolve "auto" against the correct
logical axis.

This fixes the
testing/web-platform/tests/css/css-overflow/scrollbar-gutter-scroll-into-view.html
failure.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Posted an additional change to fix the scrollbar-gutter-scroll-into-view.html failure.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59725 for changes under testing/web-platform/tests

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eb0c4c6ef434
https://hg.mozilla.org/integration/autoland/rev/a5d3125bbfa0
Make `auto` as the default ScrollIntoViewOptions. r=layout-reviewers,webidl,emilio
https://github.com/mozilla-firefox/firefox/commit/16589473999c
https://hg.mozilla.org/integration/autoland/rev/d3d82538775f
Resolve scrollIntoView "auto" against the target's writing mode to fix scrollbar-gutter-scroll-into-view regression. r=layout-reviewers,dshin

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a5d3125bbfa0
https://hg.mozilla.org/mozilla-central/rev/d3d82538775f

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot