Closed Bug 2037662 Opened 6 months ago Closed 6 months ago

Prepare privacy tests for the SRD pref flip

Categories

(Firefox :: Settings UI, task)

task

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox152 --- fixed
firefox153 --- fixed

People

(Reporter: hjones, Assigned: mkennedy)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(2 external files)

We need to make sure our tests for privacy features in preferences will pass with the SRD pref enabled or disabled. We need to:

  • create a new browser-srd.toml file for sync tests that duplicates the old /browser/components/preferences/tests/privacy/browser.toml , but with dupe-manifest=true and the browser.settings-redesign.enabled pref set to true
  • register this manifest in browser/components/preferences/moz.build
  • remove any tests that already set browser.settings-redesign.enabled to true from the old browser.toml file since these don't need to work with the pref disabled
  • clean up any code setting the SRD pref from within the test files (this will be read from the manifest)
  • remove any tests from the new manifest that are only relevant to the old UI
  • fix any failing tests
  • add new tests if there are any obvious gaps
No longer depends on: 2037661
Blocks: 2037820
No longer blocks: srd-tests
Assignee: nobody → mkennedy
Regressions: 2041072
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: no user impact, needed for release 152
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: no risk associated just testing existing functionality
  • String changes made/needed?: no
  • Is Android affected?: unknown
Attachment #9588954 - Flags: approval-mozilla-beta?
Flags: in-testsuite+
Attachment #9588954 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: