2037794 - slack.com cursor disappears when pasting sharing images

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect, P3)

Description

[Martin Balfanz [:mbalfanz]]

When sharing an image in slack, the cursor disappears. It comes back when switching channels or reloading the page.
(running Nightly on MacOS 15.7.4)

STR:

• open a slack channel. (this doesn't seem to reproduce in 1:1 conversations)
• drag an image into the input to share it
• try typing

ER:

• the cursor/caret should be visible

AR:

• there's no caret

Comment 1

[Leo Tenenbaum [:ltenenbaum]]

Can reproduce on Windows but not Ubuntu (probably some difference in how drag+drop works?)
Doesn't seem to be a regression from bug 2032191, at least. It still happens in release for me.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 3

[Leo Tenenbaum [:ltenenbaum]]

Attachment: test.html

Ah it looks like this is a problem with EditorEventListener::CleanupDragDropCaret. Specifically, if you have a situation like:

1. caret is disabled
2. user drags something over an editor
3. editor is focused (by a script, for example)
4. user drops thing

Then the caret state from step 1 is restored, so it ends up being disabled...

Comment 4

[Leo Tenenbaum [:ltenenbaum]]

Oh, the reason it's not reproducible on Linux is that the window is defocused during the drag (so step 3 can't happen). I'll take a look at this - I think it should be an easy fix (famous last words...)

Comment 5

[Leo Tenenbaum [:ltenenbaum]]

Attachment: Bug 2037794 - Set properties of original caret instead of drag+drop caret where needed. r=masayuki

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/524b0cc22bdd
https://hg.mozilla.org/integration/autoland/rev/f35f462952e6
Set properties of original caret instead of drag+drop caret where needed. r=masayuki

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6706fac649f1
https://hg.mozilla.org/integration/autoland/rev/965061556b3a
Revert "Bug 2037794 - Set properties of original caret instead of drag+drop caret where needed. r=masayuki" for causing failures at test_drag_drop_caret.html.

Comment 8

[Atila Butkovits]

Backed out for causing failures at test_drag_drop_caret.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/965061556b3a

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f35f462952e6afd8f248ac375a40964ba6067793&selectedTaskRun=VRw2We5-TmWAaxaoDsHa1g.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=566747737&repo=autoland&task=VRw2We5-TmWAaxaoDsHa1g.0&lineNumber=1908
https://treeherder.mozilla.org/logviewer?job_id=566749234&repo=autoland&task=DGz76HPKS3SI6BZwDuoxwQ.0&lineNumber=5472

Comment 9

[Leo Tenenbaum [:ltenenbaum]]

Hmm I'm not sure why synthesizePlainDragAndDrop is failing on Android here… I've had success with it in the past… I think it's fine to just disable this test on Android though.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/14e83643eeed
https://hg.mozilla.org/integration/autoland/rev/b772fac127e6
Set properties of original caret instead of drag+drop caret where needed. r=masayuki

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b772fac127e6