2037864 - build failure on openbsd since bug 2021722 - no libdl

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Landry Breuil (:gaston)]

OpenBSD doesn't have libdl, which is hardcoded in https://searchfox.org/firefox-main/source/widget/gtk/vulkantest/moz.build#18

Comment 1

[Landry Breuil (:gaston)]

this works locally:

--- i/widget/gtk/vulkantest/moz.build
+++ w/widget/gtk/vulkantest/moz.build
@@ -15,7 +15,8 @@ CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 CXXFLAGS += CONFIG["MOZ_PANGO_CFLAGS"]
 OS_LIBS += CONFIG["MOZ_X11_LIBS"]
 OS_LIBS += CONFIG["MOZ_GTK3_LIBS"]
-OS_LIBS += ["dl"]
+if CONFIG["OS_TARGET"] != "OpenBSD":
+    OS_LIBS += ["dl"]
 
 LOCAL_INCLUDES += [
     "/third_party/khronos/vulkan-headers/include",

mike, martin, good enough for you as a build system fix ?

Comment 2

[Landry Breuil (:gaston)]

Attachment: Bug 2037864: fix build on OpenBSD after bug 2021722 r?stransky

OpenBSD doesn't have libdl

Comment 3

[Tymur Boiko]

Attachment: Bug 2037864 - Avoid linking vulkantest with libdl on OpenBSD. r?stransky

Comment 4

[Tymur Boiko]

Just submitted the same patch as you wrote above

Comment 5

[Tymur Boiko]

But feel free to drop mine and submit your patch since you were the first

Comment 6

[Mike Hommey [:glandium]]

This should use CONFIG["DL_LIBS"]

Comment 7

[Landry Breuil (:gaston)]

(In reply to Mike Hommey [:glandium] from comment #6)

This should use CONFIG["DL_LIBS"]

oh, even better, haven't spotted that possibility. updated https://phabricator.services.mozilla.com/D299111 after checking it still built on openbsd, would appreciate a quick rs & landing to autoland to unbreak my buildbot..

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ddb0c91a585a
https://hg.mozilla.org/integration/autoland/rev/e1437dbd3ff1
fix build on OpenBSD after bug 2021722 r=stransky

Comment 9

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/e1437dbd3ff1