2037935 - Special-case the most common element and attribute names in Speedometer3 innerHTML/DOMParser parsing

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Description

[Henri Sivonen (:hsivonen)]

At https://searchfox.org/firefox-main/rev/a358f48a49a4d72df7b214805c4b2d2049d34a5a/parser/html/nsHtml5AttributeName.h#93 and https://searchfox.org/firefox-main/rev/a358f48a49a4d72df7b214805c4b2d2049d34a5a/parser/html/nsHtml5ElementName.h#122 , before bufToHash, check explitly for buffer contents that match the names that are the most common ones in Speedometer3.

Comment 1

[Henri Sivonen (:hsivonen)]

https://perf.compare/compare-lando-results?baseLando=193868&newLando=193869&baseRepo=try&newRepo=try&framework=13

Base revision's try run: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=193868
Local revision's try run: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=193869

Comment 2

[Henri Sivonen (:hsivonen)]

https://perf.compare/compare-lando-results?baseLando=193868&newLando=193901&baseRepo=try&newRepo=try&framework=13

Base revision's try run: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=193868
Local revision's try run: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=193901

Comment 3

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=45960

Comment 4

[Henri Sivonen (:hsivonen)]

https://perf.compare/compare-lando-results?baseLando=193868&newLando=193918&baseRepo=try&newRepo=try&framework=13

Base revision's try run: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=193868
Local revision's try run: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=193918

This currently builds on top of bug 2028401, which I hear is expected to land only after the merge day. I haven't decided yet whether to factor this into a form that could land before that patch lands.

Comment 5

[Henri Sivonen (:hsivonen)]

Attachment: Bug 2037935 - Special-case the most common element and attribute names in Speedometer3 innerHTML/DOMParser parsing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9986518e260f
https://hg.mozilla.org/integration/autoland/rev/9fca498f578b
Special-case the most common element and attribute names in Speedometer3 innerHTML/DOMParser parsing. r=smaug

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9fca498f578b

Comment 8

[Mayank Bansal]

~5% improvement on sp3-javascript-es5
~3% improvement on sp3-jquery.