2037994 - Security warnings reset button purpose could be clarified

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Stuart Colville [:muffinresearch]]

Filing this so that bug 2033440 can cover just the reset button display issue.

STR

• With browser.settings-redesign.enabled true
• Have the 1Password or a similar password manager installed.
• Go to the Privacy and Security section: about:settings#privacy
• Expand the "Security warnings" card
• See the Password manager is disabled warning.

What happens

• It's not necessarily clear to a user what clicking "reset" will do.

What should happen

• It should be clear what reset button will do.
• If I have a password management extension (which disables the built-in password manager) should this warn at all? Also noting that in this case I can click reset with the extension installed which probably shouldn't be possible if the extension is supposed to control that setting.

Comment 1

[Hanna Jones [:hjones]]

hey Ben, this might be more of an enhancement, but curious what your team thinks about this

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

There is definitely a bug having the extension controlled permissions be flagged as issues. I think if that corner case is solved, the reset button should be sufficiently clear. I thought I supported this, but managing it is actually a mess. I'll propose a patch where we just don't monitor this pref.

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 2037994 - Hide password manager warning when the preference is extension-controlled - r=hjones!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22fde722295a
https://hg.mozilla.org/integration/autoland/rev/143ca99c9d75
Hide password manager warning when the preference is extension-controlled - r=hjones

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/143ca99c9d75

Comment 6

[Negritas Sergiu, Desktop QA]

Hello! I can confirm that the issue is fixed with firefox 152.0b3 on Ubuntu 24.04, Windows 10 and MacOS 15.6.7. Updating the flags and resolution of this issue