2038137 - input type image sprite: full image is shown instead of the target part

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Viktor]

Attachment: cartIconAndroid15.jpg

Steps to reproduce:

To remove one item from the shopping cart an input of the type image is used to visualise it. The used image is a sprite.

The shopping cart sidepanel is at first of width 0 until activated, by adding an item or pressing the cart button the width is changed, revealing all cart items.

Short version of what is used:
<input type="image" src="icons_sprite.png" class="carticon cart-remove" alt="position remove">
<style>
.carticon {width: 25px !important; height: 20px; object-fit: none; background: transparent;}
.cart-remove {object-position: 0 -21px;}
</style>

Actual results:

On

• Windows 10 with Firefox 150.0.2
• Android 15 (FP5.VT2Q.C.092) with Firefox 150.0.1
• Android 16 with Firefox 150.0.1
  when input of type image is used for a sprite the full image is shown.

Expected results:

On

• Windows 11 with Firefox 140.10.2esr
• Windows 10 with Chrome
• Android 15 with Chrome
  only the targeted part of the sprite is shown

Comment 1

[Viktor]

Attachment: cartIconWin11.jpg

Comment 2

[Viktor]

Attachment: cartIconAndroid15.jpg

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Titouan Thibaud [:titouan]]

Attachment: repro.zip

I can reproduce the bug with this small repro case (from the reporter's STR), on Firefox Desktop.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sdetar, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ghess, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Pretty sure this is a regression from bug 1999100. Chrome doesn't seem to show overflow even if you explicitly set overflow: visible.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1999100

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2038137 - Include <input type=image> in elements always-clipped. r=firefox-style-system-reviewers,boris

Matches other browsers' behavior and pre-regression behavior, see
https://github.com/whatwg/html/pull/12491.

Comment 10

[Viktor]

Thanks,
adding "overflow: hidden;" to the parent element alleviates the issue.
Now it seems to only paint over the padding & margin area.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6bfa334da415
https://hg.mozilla.org/integration/autoland/rev/334867b729fb
Include <input type=image> in elements always-clipped. r=firefox-style-system-reviewers,boris

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/309c685eb91b
https://hg.mozilla.org/integration/autoland/rev/43db5e71191d
Revert "Bug 2038137 - Include <input type=image> in elements always-clipped. r=firefox-style-system-reviewers,boris" for causing wpt failures.

Comment 13

[agoloman]

Backed out for causing wpt failures.

• Backout link
• Push with failures
• Failure Log wpt
• Failure Log mochitest

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60405 for changes under testing/web-platform/tests

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/779757981da6
https://hg.mozilla.org/integration/autoland/rev/7ce8681aa688
Include <input type=image> in elements always-clipped. r=firefox-style-system-reviewers,boris

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 17

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7ce8681aa688

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot