203832 - Danlging lock file is not checked for validity

Status: RESOLVED DUPLICATE of bug 151188

(SeaMonkey :: General, defect)

Description

[Erik Walthinsen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030327 Debian/1.3-4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030327 Debian/1.3-4

After a crash of the machine or mozilla, the lock file (a symlink to
localhost:$pid) is left around.  Restarting mozilla (after rebooting the
machine) give me a dialog claiming that the profile is in use, do I want to
create/use a different one.

There appear to be zero checks for whether the PID in the symlink portion of the
lock file target actually exists and is a valid running copy of Mozilla, which
it most certainly is not.  In this most recent case the pid does indeed exist,
but is gnome-pty-helper, not mozilla.

Perhaps the body of the symlink should instead be a UNIX-domain socket linked to
the running application, so that a successful connection *proves* that the lock
is valid.  Indeed, how does running mozilla a second time open a new window in
the existing browser?  Isn't that the same mechanism that should be used to
determine liveness of the claimed lock owner?

Reproducible: Always

Steps to Reproduce:
1. Crash your machine (a. Go buy a Dell Laptop, b. Use it)
2. Start up Mozilla again, likely with another process taking the pid the lock
file references

Actual Results:  
Get a dialog that tells me that the profile is in use.

Expected Results:  
Should check the lock file, find it invalid (i.e. does not point to valid,
*running* instance of mozilla), delete it, and get on with life.

Comment 1

[Jo Hermans]

*** This bug has been marked as a duplicate of 151188 ***