2038611 - Build fails with `mach taskgraph failed in toolchain.py (exit 1)` on ja locale

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Masatoshi Kimura [:emk]]

$ ./mach build
 0:00.68 W Warnings in third-party code are being suppressed from the terminal output. Use --show-all-warnings or --verbose to see them.
 0:00.68 W All warnings will still be dumped to F:/m/firefox/obj-x86_64-pc-windows-msvc\.mozbuild\logs\build\warnings_*.json at the end of the build.
Streaming resource usage profile to: F:/m/firefox/obj-x86_64-pc-windows-msvc\.mozbuild\logs\build\profile_log_20260511_201933.json
 0:01.10 Clobber not needed.
 0:01.10 Config object not found by mach.
 0:01.56 Using Python 3.12.10 from C:\Users\xxxx\.mozbuild\srcdirs\firefox-5a3f146ade88\_virtualenvs\build\Scripts\python.exe
 0:01.56 Adding configure options from F:\m\firefox\mozconfig
 0:01.56   --enable-bootstrap
 0:01.56   --enable-optimize
 0:01.56   --with-redist
 0:01.56   ENABLE_CLANG_PLUGIN=1
 0:01.56 checking for vcs source checkout... git
 0:01.59 checking for a shell... C:/mozilla-build/msys2/usr/bin/sh.exe
 0:01.59 checking for host system type... x86_64-pc-windows-msvc
 0:01.59 checking for target system type... x86_64-pc-windows-msvc
 0:01.77 checking whether cross compiling... no
 0:01.81 checking if configuration file confvars.sh exists... F:/m/firefox/browser/confvars.sh
 0:01.81 checking if configuration file configure.sh exists... F:/m/firefox/browser/branding/unofficial/configure.sh
 0:01.83 checking for Python 3... C:/Users/xxxx/.mozbuild/srcdirs/firefox-5a3f146ade88/_virtualenvs/build/Scripts/python.exe (3.12.10)
 0:01.84 checking for git... C:/mozilla-build/msys2/mingw64/bin/git.exe
 0:01.85 checking for Git version... 2.49.0.windows.1
 0:01.86 checking for MozillaBuild directory... C:\mozilla-build\
 0:01.86 checking for MozillaBuild version... 4.2.1
 0:04.81 W WARNING: mach taskgraph failed in toolchain.py (exit 1)
 0:04.85 checking for ccache... not found
 0:04.85 checking for the target C compiler... not found
 0:04.86 DEBUG: _cc: Looking for clang-cl
 0:04.86 E ERROR: Cannot find the target C compiler
 0:04.92 E *** Fix above errors and then restart with "./mach build"

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: mach_taskgraph_console_out

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: mach_taskgraph_params.json

Comment 3

[Masatoshi Kimura [:emk]]

Regression range: https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=c94aff4eb3be953d56671b8851203d3aa7946b9b&tochange=00856bc4cea02aad8bbee8c81235e84e2d1f46fe

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: log_at_00856bc4cea02aad8bbee8c81235e84e2d1f46fe

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:Sylvestre, since you are the author of the regressor, bug 2023411, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Bug 2038611 - Pass text encoding explicitly when reading android_os_to_api_map.yaml. r?#linter-reviewers

We can't assume that the text encoding is UTF-8 on Windows.

Comment 7

[Masatoshi Kimura [:emk]]

This bug happens because android_os_to_api_map.yaml contains a non-ASCII character (→) and the default text encoding is not UTF-8 on Windows. On Western locales, the UTF-8-encoded byte sequence for → (E2 86 92) happens to valid as windows-1252, but it causes UnicodeDecodeError on Japanese locale because it is not valid as cp932.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4724c537c99e
https://hg.mozilla.org/integration/autoland/rev/a653c30ddb3b
Pass text encoding explicitly when reading android_os_to_api_map.yaml. r=linter-reviewers,sylvestre

Comment 9

[Sylvestre Ledru [:Sylvestre]]

thanks!

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a653c30ddb3b