2038749 - Match sub-panes in search and attach the matches to their triggering button

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P2)

Description

[Mark Striemer [:mstriemer]]

We have some sub-panes that are missing their search-l10n-ids for finding the content shown in the sub-pane. Rather than going through all of these pages and filling that out, we could do a general solution where we search the sub-pane elements but link the matches back to their host button that triggers the sub-pane

We can update sub-pane buttons to do something like data-opens-pane="subPaneId" and when we encounter a match we treat the match as if its from a search-l10n-ids

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 2038749 - Automatically search sub-panes in Settings r?#settings-reviewers!

When an element is marked with data-load-pane="paneFoo" (set with
loadPane: "foo" in the config) then that pane will be searched and the
element will be highlighted as a keyboard match based on matches in the
related pane (or any sub-panes of that pane).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4d6cd03a62a1
https://hg.mozilla.org/integration/autoland/rev/6c243157c086
Automatically search sub-panes in Settings r=tgiles,thecount

Comment 5

[rperta]

https://hg.mozilla.org/mozilla-central/rev/6c243157c086