2038859 - Improve accessibility of the new tab groups list

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser: Tab Groups, task)

Description

[Stephen Thompson [:sthompson]]

Review the tab groups list in the application menu for its accessibility. Ensure a good experience for keyboard users, screen reader users, visually impaired users, etc.

Comment 1

[Stephen Thompson [:sthompson]]

Attachment: Bug 2038859 - don't read out tab group icon in tab groups list r=jswinarton

This addresses two accessibility issues related to the tab group icon in the tab groups list:

1. use presentation role so that screen readers do not try to describe it
2. fall back to using the text color on the SVG icon in forced colors mode

The tab group colors do not have global forced colors fallbacks, so this patch just addresses that issue locally in the tab groups list.

Comment 2

[Stephen Thompson [:sthompson]]

Jeremy's previous work on the tab groups list resulted in a good keyboard navigation experience and a screen reader experience that seemed to me identical to the List All Tabs menu's list of tab groups. I took the opportunity during this a11y review to take care of two small issues.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c20af1774585
https://hg.mozilla.org/integration/autoland/rev/07c551c6fe32
don't read out tab group icon in tab groups list r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,dao

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/07c551c6fe32