2038988 - [tablets] The tab thumbnails seem small on the tab group bottom sheet

Status: RESOLVED FIXED

(Firefox for Android :: Tabs, defect)

Description

[Mira Lobontiu (Android QA)]

Attachment: TabsInGroup.jpg

Steps to reproduce

1. On a tablet, create a tab group a couple of tabs.
2. Open the created tab group, by tapping on it.
3. Observe the tab thumbnails.

Expected behavior

The tab thumbnails are displayed bigger - not as big as the thumbnails from the tabs tray.

Actual behavior

The tab thumbnails inside a tab group seem a bit small on tablets.

Device information

• Firefox version: Nightly 152.0a1 from 5/12
• Android device: Pixel tablet (Android 16)

Comment 1

[Noah Bond [:007]]

This is in next sprint's backlog.

Technical notes:

• The TabLayout composable responsible for rendering grid currently does a size check based off of the app Window size.
• We'll need to change this to check the parent Composable's width instead, if we want to continue using this component inside of a BottomSheet.

Comment 2

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2038988: Adjust the thumbnail count in TabLayout by the Composable width, not screen width

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4c07590ce4b8
https://hg.mozilla.org/integration/autoland/rev/c4dbc719ab58
Adjust the thumbnail count in TabLayout by the Composable width, not screen width r=android-reviewers,007

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c4dbc719ab58

Comment 5

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:jdelorenzo, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Julie De Lorenzo [:jdelorenzo]]

I didn't hear back when I asked about uplifting in our project Slack channel so I think this one can ride the trains.