2038991 - Update map_gecko_prefs_to_enrollment_slugs_and_update_store to have a param to signal not updating Gecko

Status: VERIFIED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[Olivia Hall [:olivia]]

Update map_gecko_prefs_to_enrollment_slugs_and_update_store to have a param that prevents updating the experiment with Gecko. Sometimes, we just need the information refreshed.

ToDo:

• Expand map_gecko_prefs_to_enrollment_slugs_and_update_store with a param like update_gecko that guards set_gecko_prefs_state (maybe others)
• Update commit_and_update to set the flag here
• register_previous_gecko_pref_states should call writer.commit()?; and call self.database_cache.commit_and_update_without_telling_gecko(), which calls map_gecko_prefs_to_enrollment_slugs_and_update_store with update_gecko= false
• Thoroughly test that this behaves as expected

Reason for this change is this is causing the dbcache can go out of sync. No identified bugs at this time, but it has the potential to introduce them in the future.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/application-services] Bug 2038991 - Update Cache when calling register_previous_gecko_pref_states (#7369)

Comment 2

[BMO Github Automation]

Authored by https://github.com/ohall-m
https://github.com/mozilla/application-services/commit/242220acf4da784812dd2ec0495f3465a4aa4da8
[main] Bug 2038991 - Update Cache when calling register_previous_gecko_pref_states (#7369)

Comment 3

[Mira Lobontiu (Android QA)]

Hi, Olivia
Could you provide us some steps in order to verify this fix?
Thank you!

Comment 4

[Olivia Hall [:olivia]]

Thanks, Mira!

Sure, a spot-check retest of this this case or this case will probably be the best ones to run.

The patch adjusted how original values are saved in the database. So, the risk is if the database stopped saving the original value as expected or caused an unexpected issue somewhere else. That original value is then used to reset the pref back.

Randomly selecting any of the cases involved in unenrollment and restoring to an original value would be good for verification.

Thank you!

Comment 5

[Patriciu Pop [:ppop], Ecosystem QA]

I'll mark this as verified, since I went through all the unenrollment scenarios and in each case the prefs were correctly reset to their default values. Tested using Firefox Nightly 153.0a1 (Build #2016163802) on Android 11.