Closed Bug 2039135 Opened 4 months ago Closed 4 months ago

[wpt-sync] Sync PR 59836 - [Masonry] Measure subgridded items against standalone axis

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 59836 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59836
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[Masonry] Measure subgridded items against standalone axis

When measuring subgridded items, derive the stacking-axis containing
block from the subgrid's own track collection when one is available.

Also, update CreateConstraintSpaceForMeasure to remove the passed in
track collection, and use the SubgriddedItemData to get track
collection info. We used this input to also know when to provide a
definite constraint in the grid axis, so replace it with a bool instead.

This also removes a TODO about doing a similar change in
CreateConstraintSpaceForLayout since this method is never used for
subgridded items, only subgrids themselves.

Adds 18 new WPT tests covering the standalone-axis containing-block
behaviour in both row and column grid-lanes. 8 of the tests are still
failing because they are using indefinite track sizes, and currently at
the point this is called, we only will know the subgrid's standalone
track sizes if they are definite. A follow up change will be needed to
get those cases working.

Bug: 343257585
Change-Id: I533ea6d3e79403b233f0d7b4eff9e198dd1ac980

Reviewed-on: https://chromium-review.googlesource.com/7829563
WPT-Export-Revision: bf0ac3cca6a82997edb2d6fa612ec262d37ce1a4

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 35 tests

Status Summary

Firefox

PASS: 11[GitHub] 15[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 7[GitHub] 20[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 2
FAIL: 16

Safari

PASS: 14
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/d168047005a5
https://hg.mozilla.org/mozilla-central/rev/258f49221fba

Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.