2039485 - The blocked trackers log is ignoring some tracker categories

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, defect, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

Steps to reproduce

1. With the "Privacy report" enabled from Settings -> Homepage, visit the homepage and make a record of the current number of trackers blocked
2. Access cnn.com, wait a few seconds after the page is fully loaded (to ensure all trackers loaded also), make a record of the tracker blocked number shown in the security panel
3. Tap on CNN's "Accept all cookies" button, wait for the page to reload and a few seconds after the page is fully loaded (to ensure all trackers loaded also), make a record of the tracker blocked number shown in the security panel
4. Go to home and check the trackers blocked number shown in the privacy report

Expected behavior

The privacy report numbers increase matches the total number of trackers blocked on CNN (after step 2 and 3).

Actual behavior

The privacy report numbers may be higher than the total number of trackers blocked on CNN (after step 2 and 3).

Additional information

After looking into why this might happen it seems like not all tracker categories persisted in Gecko's database are recognized when parsing the trackers blocked data from the trackers log API.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2039485 - part 1 - Ensure the trackers panel doesn't show fewer trackers blocked than we read from the db r=#android-reviewers

BLOCKED_EMAILTRACKING_CONTENT, PURGED_BOUNCETRACKER and REPLACED_FINGERPRINTING_CONTENT
are categories for which trackers are added in the tracking content database but were
previously skipped from the results returned by FetchTrackingLogUserCase.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2039485 - part 2 - Ensure each blocked tracker has a single primary category in TrackerBuckets r=#android-reviewers

Previously, an origin with both content-block and cookie-block events
for the same page load would be added to both TRACKING_CONTENT and
CROSS_SITE_TRACKING_COOKIES buckets.
This would make the per-category numbers in the protection panel sum
to roughly 2× the pill total on cookie-heavy sites.
CROSS_SITE_TRACKING_COOKIES buckets. This made the per-category numbers
in the protection panel sum to roughly 2× the pill total on cookie-heavy
sites.

These changes will ensure picking a single primary category per origin
using a priority order that mirrors TrackingDBService.identifyType so
DB-classified type aligns with panel-displayed category: FINGERPRINTERS,
CRYPTOMINERS, SOCIAL_MEDIA_TRACKERS, TRACKING_CONTENT,
CROSS_SITE_TRACKING_COOKIES.

Comment 3

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:Gela, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9cdf33f3bd7
https://hg.mozilla.org/integration/autoland/rev/e2d8ec4dee10
part 1 - Ensure the trackers panel doesn't show fewer trackers blocked than we read from the db r=android-reviewers,geckoview-reviewers,timhuang,ohall,geckoview-api-reviewers
https://github.com/mozilla-firefox/firefox/commit/03838268944a
https://hg.mozilla.org/integration/autoland/rev/c87c16294416
part 2 - Ensure each blocked tracker has a single primary category in TrackerBuckets r=android-reviewers,Roger

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/e2d8ec4dee10
https://hg.mozilla.org/mozilla-central/rev/c87c16294416