Closed
Bug 2039492
Opened 6 months ago
Closed 6 months ago
[riscv64] Make ABIKind::System FP calls conforming to psABI
Categories
(Core :: JavaScript Engine: JIT, task)
Tracking
()
RESOLVED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: csmantle, Assigned: csmantle)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
RISC-V's ELF psABI specifies the following:
A real floating-point argument is passed in a floating-point argument register if [...] at least one floating-point argument register is available. Otherwise, it is passed according to the integer calling convention.
-- [^0]
However, we currently push all extra FP args onto the stack without considering the available GPRs[^1].
| Assignee | ||
Updated•6 months ago
|
Blocks: sm-riscv64
Hardware: Unspecified → RISCV64
| Assignee | ||
Comment 1•6 months ago
|
||
Updated•6 months ago
|
Assignee: nobody → webmaster
Status: NEW → ASSIGNED
Pushed by webmaster@csmantle.top:
https://github.com/mozilla-firefox/firefox/commit/d95a1a99e191
https://hg.mozilla.org/integration/autoland/rev/d9f46467546b
[riscv64] Make floating point callconv conforming to psABI. r=jandem
Comment 3•6 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Updated•4 months ago
|
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in
before you can comment on or make changes to this bug.
Description
•