Closed Bug 2039574 Opened 6 months ago Closed 5 months ago

Update telemetry probe to include new open tabs panel in revamped sidebar

Categories

(Firefox :: Sidebar, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: nsharpley, Assigned: dr.seed.lu, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar][outreachy-sidebar-2026])

Attachments

(1 external file)

1 . In browser/components/sidebar/metrics.yaml

  • Add open_tabs_icon_click event metric
  1. See bug 2023951 for history and synced_tabs implementation and bug 2024640 for bookmarks implementation. This should record when an open tabs row has been clicked.
  • sidebar.link.open_tabs is the probe to use
  • add tests to verify new probe

Note: requires a data review URL before landing

No longer depends on: sidebar-opentabs

This adds telemetry for the Open Tabs sidebar panel. It follows the
same pattern bug 2023951 used for history and synced tabs, and bug
2024640 used for bookmarks.

There are two parts:

  • A new open_tabs_icon_click event in metrics.yaml. It records when
    the user clicks the Open Tabs icon in the sidebar launcher, with a
    sidebar_open boolean indicating if the sidebar was open or
    collapsed at the time. To link this up, I added gleanClickEvent: Glean.sidebar.openTabsIconClick to the viewOpenTabsSidebar entry
    in browser-sidebar.js.

  • A new open_tabs label on the existing sidebar.link labeled
    counter. I record it from sidebar-opentabs.mjs onPrimaryAction so
    it fires when the user clicks a tab row to switch to that tab.

For tests, I added the viewOpenTabsSidebar entry to the icon-click
test map in browser_glean_sidebar.js, and a new
test_open_tabs_link_glean_probe that clicks a row in the panel and
checks the counter went from 0 to 1.

Assignee: nobody → dr.seed.lu
Status: NEW → ASSIGNED

Please I am requesting a data review for the new Open Tabs sidebar panel metrics in this patch (D306333).

Both additions extend telemetry families that already exist on the sidebar:

  1. sidebar.open_tabs_icon_click (event)
    This has the same shape as sidebar.history_icon_click, sidebar.bookmarks_icon_click, and sidebar.synced_tabs_icon_click, which were reviewed under https://phabricator.services.mozilla.com/D226681.
    It fires when the user clicks the Open Tabs icon in the sidebar launcher, and includes a boolean sidebar_open to indicate whether the sidebar was open or collapsed when they clicked.

  2. sidebar.link.open_tabs (new label on the existing sidebar.link labeled counter)
    This adds an open_tabs label to the existing sidebar.link counter. The other labels are bookmarks, history, and synced_tabs.
    It records when the user clicks a tab row in the Open Tabs panel to switch to that tab.

Both metrics use:

  • Category: Interaction (data_sensitivity 1)
  • Expires: never
  • Sent in: events ping

The goal is to measure how users engage with the Open Tabs sidebar panel (currently behind the sidebar.openTabsPanel.enabled pref).
It matches the telemetry we already collect for the History, Synced Tabs, and Bookmarks sidebar panels.

A data-review reviewer could please leave a data-review: r+ if this looks ok.

Nikkis, please could you point me to a data-review reviewer for this?

Thank you.

Flags: needinfo?(nsharpley)
Attachment #9596731 - Flags: data-review?(chutten)
Attachment #9596731 - Flags: data-review?(chutten)
Flags: needinfo?(nsharpley)
Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6174a5c49de6 https://hg.mozilla.org/integration/autoland/rev/d8d83163b9f5 Update telemetry probe to include new open tabs panel in revamped sidebar r=nsharpley,kcochrane
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: