Update telemetry probe to include new open tabs panel in revamped sidebar
Categories
(Firefox :: Sidebar, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: nsharpley, Assigned: dr.seed.lu, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-sidebar][outreachy-sidebar-2026])
Attachments
(1 external file)
1 . In browser/components/sidebar/metrics.yaml
- Add
open_tabs_icon_clickevent metric
- See bug 2023951 for history and synced_tabs implementation and bug 2024640 for bookmarks implementation. This should record when an open tabs row has been clicked.
sidebar.link.open_tabsis the probe to use- add tests to verify new probe
Note: requires a data review URL before landing
Updated•6 months ago
|
| Reporter | ||
Updated•6 months ago
|
This adds telemetry for the Open Tabs sidebar panel. It follows the
same pattern bug 2023951 used for history and synced tabs, and bug
2024640 used for bookmarks.
There are two parts:
-
A new
open_tabs_icon_clickevent in metrics.yaml. It records when
the user clicks the Open Tabs icon in the sidebar launcher, with a
sidebar_openboolean indicating if the sidebar was open or
collapsed at the time. To link this up, I addedgleanClickEvent: Glean.sidebar.openTabsIconClickto the viewOpenTabsSidebar entry
in browser-sidebar.js. -
A new
open_tabslabel on the existingsidebar.linklabeled
counter. I record it from sidebar-opentabs.mjs onPrimaryAction so
it fires when the user clicks a tab row to switch to that tab.
For tests, I added the viewOpenTabsSidebar entry to the icon-click
test map in browser_glean_sidebar.js, and a new
test_open_tabs_link_glean_probe that clicks a row in the panel and
checks the counter went from 0 to 1.
Updated•5 months ago
|
Please I am requesting a data review for the new Open Tabs sidebar panel metrics in this patch (D306333).
Both additions extend telemetry families that already exist on the sidebar:
-
sidebar.open_tabs_icon_click(event)
This has the same shape assidebar.history_icon_click,sidebar.bookmarks_icon_click, andsidebar.synced_tabs_icon_click, which were reviewed under https://phabricator.services.mozilla.com/D226681.
It fires when the user clicks the Open Tabs icon in the sidebar launcher, and includes a booleansidebar_opento indicate whether the sidebar was open or collapsed when they clicked. -
sidebar.link.open_tabs(new label on the existingsidebar.linklabeled counter)
This adds anopen_tabslabel to the existingsidebar.linkcounter. The other labels arebookmarks,history, andsynced_tabs.
It records when the user clicks a tab row in the Open Tabs panel to switch to that tab.
Both metrics use:
- Category: Interaction (data_sensitivity 1)
- Expires: never
- Sent in: events ping
The goal is to measure how users engage with the Open Tabs sidebar panel (currently behind the sidebar.openTabsPanel.enabled pref).
It matches the telemetry we already collect for the History, Synced Tabs, and Bookmarks sidebar panels.
A data-review reviewer could please leave a data-review: r+ if this looks ok.
Nikkis, please could you point me to a data-review reviewer for this?
Thank you.
Updated•5 months ago
|
Updated•5 months ago
|
| Reporter | ||
Updated•5 months ago
|
Updated•4 months ago
|
Description
•