Closed Bug 2039789 Opened 6 months ago Closed 6 months ago

Large increase in Base Content JS and Base Content Explicit AWSY measurements from bug 2004011

Categories

(Core :: JavaScript: GC, defect, P3)

defect

Tracking

()

RESOLVED FIXED
152 Branch
Tracking Status
firefox-esr140 --- unaffected
firefox150 --- unaffected
firefox151 --- unaffected
firefox152 --- disabled
firefox153 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

(Regression)

Details

(Keywords: perf-alert, regression)

Attachments

(1 external file)

Assignee: nobody → jcoppeard

Set release status flags based on info from the regressing bug 2004011

The problem here was that the total chunk counts were reported including the
shared atoms zone but when iterating chunks this zone was not considered. This
meant the memory reporting overcounted the amount of used memory.

The fix is to also iterate chunks in the shared atoms zone.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Duplicate of this bug: 2040313

(In reply to Cosmin Sabou [:CosminS] from comment #4)

https://hg.mozilla.org/mozilla-central/rev/bcb7a5bb53dd

Perfherder has detected a awsy performance change from push bcb7a5bb53dd6fa378773db79f3cca8050f0aeef.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
35% Base Content JS (doc) macosx1470-64-shippable fission 2,388,744.00 bytes -> 1,553,160.00 bytes
35% Base Content JS (doc) windows11-64-25h2-shippable fission 2,389,961.33 bytes -> 1,554,584.00 bytes
10% Base Content Explicit (doc) macosx1470-64-shippable fission 8,234,322.00 bytes -> 7,391,449.33 bytes
10% Base Content Explicit (doc) windows11-64-25h2-shippable fission 8,708,328.00 bytes -> 7,868,363.33 bytes
6% JS (doc) linux2404-64-shippable fission tp6 185,571,231.82 bytes -> 174,190,271.01 bytes

Need Help or Information?

If you have any questions, please reach out to fbilt@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: