2039847 - Add events for tab interactions

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Comment 2

[Dave Townsend [:mossop] (PTO until July 20)]

Attachment: Bug 2039847: Fix intermittent test failure in browser_tab_groups_tab_interactions_telemetry.js. r=#tabbrowser-reviewers!

Comment 3

[Dave Townsend [:mossop] (PTO until July 20)]

Attachment: Bug 2039847: Normalize telemetry source naming in tabbrowser. r=#tabbrowser-reviewers!

Comment 4

[Dave Townsend [:mossop] (PTO until July 20)]

Attachment: Bug 2039847: Normalize the metricsContext parameter. r=#tabbrowser-reviewers!

This saves us spreading and breaking out the metrics context in various places and makes the following patch easier.

Comment 5

[Dave Townsend [:mossop] (PTO until July 20)]

Attachment: Bug 2039847: Add events for tab interactions. r=#tabbrowser-reviewers!

We send both events (which can be throttled if the rate is too high) and counters for raw numbers.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8ab336b80008
https://hg.mozilla.org/integration/autoland/rev/d5cc07a71215
Fix intermittent test failure in browser_tab_groups_tab_interactions_telemetry.js. r=tabbrowser-reviewers,jswinarton

Comment 7

[rperta]

https://hg.mozilla.org/mozilla-central/rev/d5cc07a71215

Comment 8

[Dave Townsend [:mossop] (PTO until July 20)]

Attachment: Bug 2039847: Change some potential mischaracterisations in the tab groups telemetry. r=sthompson!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e049abbb9f71
https://hg.mozilla.org/integration/autoland/rev/ff298d78d479
Normalize telemetry source naming in tabbrowser. r=tabbrowser-reviewers,omc-reviewers,jswinarton,mviar

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ff298d78d479

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/822c79488936
https://hg.mozilla.org/integration/autoland/rev/e36be8043639
Normalize the metricsContext parameter. r=tabbrowser-reviewers,fxview-reviewers,dao,nsharpley

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/93bdd7838e35
https://hg.mozilla.org/integration/autoland/rev/16fe97b115d9
Revert "Bug 2039847: Normalize the metricsContext parameter. r=tabbrowser-reviewers,fxview-reviewers,dao,nsharpley" for causing bc failures @ browser_sma_create_group_from_current_tab.js

Comment 13

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures @ browser_sma_create_group_from_current_tab.js

Backout link

Push with failures

Failure log

This one too: https://treeherder.mozilla.org/logviewer?job_id=575038265&repo=autoland&task=JZoKYxd6QUaq_kJIlBZKVA.0&lineNumber=43139

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/24a5270acd93
https://hg.mozilla.org/integration/autoland/rev/b9a69fec883c
Normalize the metricsContext parameter. r=tabbrowser-reviewers,fxview-reviewers,dao,nsharpley,omc-reviewers,emcminn
https://github.com/mozilla-firefox/firefox/commit/b55dce01dac9
https://hg.mozilla.org/integration/autoland/rev/48f92b0566a1
Change some potential mischaracterisations in the tab groups telemetry. r=sthompson,tabbrowser-reviewers

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b9a69fec883c
https://hg.mozilla.org/mozilla-central/rev/48f92b0566a1

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9382120b0692
https://hg.mozilla.org/integration/autoland/rev/6c57eeacfbce
Add events for tab interactions. r=tabbrowser-reviewers,mstriemer,dao,sthompson

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6c57eeacfbce