2039852 - Save All button not using XDG desktop portal for file dialogs (but correctly uses the kde file dialog when saving individual attachments)

Status: NEW

(Core :: Widget: Gtk, defect)

Description

[kappa]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:150.0) Gecko/20100101 Firefox/150.0

Steps to reproduce:

I am using the flatpak version of Thunderbird and have xdg-desktop-portal-kde installed on linux kde. The file picker correctly uses the kde file dialog when saving individual attachments (using "Save" button or "Save As..." on emails with multiple attachments). However, when using the "Save All" button to save attachments in an email with multiple attachments it reverts to using the GTK file dialog. It might just be that this button has not been set to using the dialog xdg-desktop-portal dialog like the normal save button.

Comment 1

[kappa]

Looking a bit more further into this, I think this bug report at kde might be related as issue appears similar

Comment 2

[kappa]

https://bugs.kde.org/show_bug.cgi?id=431514

Comment 3

[Magnus Melin [:mkmelin]]

Can you try v150 or later?

Comment 4

[kappa]

(In reply to Magnus Melin [:mkmelin] from comment #3)

Can you try v150 or later?

I have tested using Thunderbird 150.0.2 (64-bit) (non-flatpak), it has the same issue as above. Single attachments show the kde dialog while multiple attachments show the gtk dialog.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 2039852 - Fix for Save All button not using XDG desktop portal for file dialogs. r=jhorak,emilio

On portal < v3, the call fails -> we get the OpenNonPortal() fallback.
With the patch, for supported versions, the folder picker goes through the portal as expected.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

I don't see how comment 5 works. The issue seems to be that your portal is too old and doesn't support the needed call... You need to update your xdg portal implementation. But I might be missing something?

Comment 7

[Magnus Melin [:mkmelin]]

kappa: can you provide more version details about your system?

Comment 8

[kappa]

I am using:
Solus 4.9 (x86-64)
KDE Plasma Version: 6.6.4
KDE Frameworks Version: 6.25.0
Qt Version: 6.10.3
xdg-desktop-portal (1.20.4) and xdg-desktop-portal-kde (6.6.4).

Thunderbird is version 140.10.2esr using Flatpak (also tested and reproduced on Thunderbird 150.0.2 (64-bit) (non-flatpak)) .

If you need anything else, let me know.