2039881 - Enable text modules by default

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Eemeli Aro [:eemeli]]

Once the 152 merge day has passed (18 May), let's enable text module imports by default.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox153 (nightly). However, the bug still isn't assigned.

:sdetar, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 2

[Eemeli Aro [:eemeli]]

Attachment: Bug 2039881 Part 1 - Enable text modules in beta/release. r?dminor!

Comment 3

[Eemeli Aro [:eemeli]]

Attachment: Bug 2039881 Part 2 - Enable text modules by default. r?dminor!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dde67447c3e0
https://hg.mozilla.org/integration/autoland/rev/96df47365664
Part 1 - Enable text modules in beta/release. r=dminor,extension-reviewers,dom-worker-reviewers,asuth
https://github.com/mozilla-firefox/firefox/commit/d9d4763c33c8
https://hg.mozilla.org/integration/autoland/rev/95a8f0a0e2bd
Part 2 - Enable text modules by default. r=dminor,extension-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/96df47365664
https://hg.mozilla.org/mozilla-central/rev/95a8f0a0e2bd

Comment 6

[Pascal Chevrel (relman team) -> :pascalc]

Eemili, should we have a release note for that?
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Comment 7

[Eemeli Aro [:eemeli]]

Maybe? I've not kept track of what JS language features we end up release noting.

Dan, do you think we ought to have a release note for text module imports?

Comment 8

[Dan Minor [:dminor]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Adds support for importing text using the JavaScript module system.
[Affects Firefox for Android]: Yes
[Suggested wording]: Developers can now use the text import attribute to import text files using the module system.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import/with

Comment 9

[Pascal Chevrel (relman team) -> :pascalc]

Note added to our 153 nightly release notes in the Web Platform section with this wording:

Developers can now use the text import attribute to import text files using the module system.

I am keeping the relnote-firefox? flag set until we include this note in our final 153 release notes, thanks.

Comment 10

[Eemeli Aro [:eemeli]]

Might be better to link directly to the relevant section on that page:

https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/import/with#text_modules_type_text

Comment 11

[Pascal Chevrel (relman team) -> :pascalc]

(In reply to Eemeli Aro [:eemeli] from comment #10)

Might be better to link directly to the relevant section on that page:

https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/import/with#text_modules_type_text

Done

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

I am keeping the relnote-firefox? flag set until we include this note in our final 153 release notes, thanks.

(Change of internal process)

Comment 13

[Hamish Willee]

FF153 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/44457 (in review).