Closed
Bug 2039896
Opened 4 months ago
Closed 4 months ago
Fix definition of secondary button label in ipProtection.ftl
Categories
(Firefox :: IP Protection, task)
Firefox
IP Protection
Tracking
()
RESOLVED
FIXED
152 Branch
| Tracking | Status | |
|---|---|---|
| firefox152 | --- | fixed |
People
(Reporter: rking, Assigned: rking)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fx-vpn])
Attachments
(1 file)
Currently, the definition of ipprotection-feature-introduction-button-secondary-remove is set directly in ipProtection.ftl, but it needs to be set on a label attribute in order to be used in a split button dropdown in the message JSON, like so:
ipprotection-feature-introduction-button-secondary-remove-1 =
.label = Remove VPN from toolbar
Since this moves an existing string, we should set up a fluent migration to avoid having to re-translate the same text:
https://firefox-source-docs.mozilla.org/l10n/migrations/fluent.html
Pushed by rking@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/d666e3a28c0d
https://hg.mozilla.org/integration/autoland/rev/6f6b8d053355
Fix definition of secondary button label in ipProtection.ftl - r=ip-protection-reviewers,fluent-reviewers,kpatenio,bolsson
Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox152:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
|
||
Updated•4 months ago
|
QA Whiteboard: [qa-triage-done-c153/b152]
|
||
Updated•3 months ago
|
Whiteboard: [fx-vpn]
|
||
Updated•3 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•