Closed Bug 204 Opened 22 years ago Closed 22 years ago

warning fix : ns/lib/layout/laytable.c

Categories

(MozillaClassic Graveyard :: Layout, defect, P3, trivial)

1998-03-31
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: rick, Assigned: nisheeth_mozilla)

Details

Created by Rick Osborne (rick@rixsoft.com) on Monday, April 13, 1998 9:38:21 PM PDT
Additional Details :
(In the continuing quest to eliminate even compiler warnings
... )

These were fun.  Apparently the table code was massively
overhauled and so someone #ifdef-ed and commented out a
whole bunch of stuff, including the code that used these
vars.

(3246) : warning C4101: ''save_state_pushes'' : unreferenced
local variable
(3246) : warning C4101: ''tag_end_ptr'' : unreferenced local
variable
(3246) : warning C4101: ''save_state_pops'' : unreferenced
local variable
(3246) : warning C4101: ''tag_ptr'' : unreferenced local
variable
(3246) : warning C4101: ''save_diff_state'' : unreferenced
local variable
(3246) : warning C4101: ''tag_list'' : unreferenced local
variable
(3774) : warning C4101: ''save_state_pushes'' : unreferenced
local variable
(3774) : warning C4101: ''tag_end_ptr'' : unreferenced local
variable
(3774) : warning C4101: ''save_state_pops'' : unreferenced
local variable
(3774) : warning C4101: ''tag_ptr'' : unreferenced local
variable
(3774) : warning C4101: ''elem_list'' : unreferenced local
variable
(3774) : warning C4101: ''save_diff_state'' : unreferenced
local variable
(3774) : warning C4101: ''tag_list'' : unreferenced local
variable

--- laytable.old.c      Wed Apr 08 17:52:27 1998
+++ laytable.c  Tue Apr 14 00:39:51 1998
@@ -2630,5 +2630,5 @@ lo_RelayoutCaptionSubdoc(MWContext
*cont
        lo_DocState *new_state;
-       PA_Tag *tag_list;
-       PA_Tag *tag_ptr;
-       PA_Tag *tag_end_ptr;
+       /* ifdef-ed out of service: PA_Tag *tag_list; */
+       /* Commented and ifdef-ed out of service: PA_Tag
*tag_ptr; */
+       /* Commented out of service: PA_Tag *tag_end_ptr; */
        int32 doc_id;
@@ -2646,5 +2646,5 @@ lo_RelayoutCaptionSubdoc(MWContext
*cont
        NET_ReloadMethod save_force;
-       Bool save_diff_state;
-       int32 save_state_pushes;
-       int32 save_state_pops;
+       /* ifdef-ed out of service: Bool save_diff_state; */
+       /* ifdef-ed out of service: int32 save_state_pushes;
*/
+       /* ifdef-ed out of service: int32 save_state_pops;
*/
        lo_DocLists *doc_lists;
@@ -3259,5 +3259,5 @@ lo_RelayoutCell(MWContext *context,
lo_D
        lo_DocState *new_state;
-       PA_Tag *tag_list;
-       PA_Tag *tag_ptr;
-       PA_Tag *tag_end_ptr;
+       /* Unused: PA_Tag *tag_list; */
+       /* COmmented out of service: PA_Tag *tag_ptr; */
+       /* Commented out of service: PA_Tag *tag_end_ptr; */
        int32 doc_id;
@@ -3275,5 +3275,5 @@ lo_RelayoutCell(MWContext *context,
lo_D
        NET_ReloadMethod save_force;
-       Bool save_diff_state;
-       int32 save_state_pushes;
-       int32 save_state_pops;
+       /* Unused: Bool save_diff_state; */
+       /* Unused: int32 save_state_pushes; */
+       /* Unused: int32 save_state_pops; */
        lo_DocLists *doc_lists;
@@ -3283,3 +3283,3 @@ lo_RelayoutCell(MWContext *context,
lo_D
        int32 hold_current_layer_num;
-       LO_Element * elem_list;
+       /* Commented out of service: LO_Element * elem_list;
*/
Assignee: nobody → {}
Component: Layout
Assignee: {} → djw
Assignee: djw → nisheeth
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
This was fixed a while back.  Thanks Rick.
VERIFIED due to no changes in over a year
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.