204008 - checksetup.pl doesn't set correct permissions on js/ directory

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Dave Miller [:justdave]]

checksetup.pl doesn't set correct permissions on js/ directory

Just cvs updated a 2.17.1 to 2.17.4 and picked up the js directory, which
checked out with owner-only privs.  Running checksetup.pl did not fix the
directory or its contents to be readable by the webserver.

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch

Comment 2

[Dave Miller [:justdave]]

-> me

Comment 3

[Zach Lipton [:zach]]

Comment on attachment 122171 [details] [diff] [review]
Patch

>@@ -1183,6 +1184,7 @@
>     fixPerms('Bugzilla', $<, $gid, 022, 1);
>     fixPerms('template', $<, $gid, 022, 1);
>     fixPerms('css', $<, $gid, 022, 1);
>+    fixPerms('js', $<, $webservergid, 022, 1);

$webservergid doesn't exist here because the user didn't set webservergroup. I
think you mean $gid instead (in the second block of the patch)?

Comment 4

[Dave Miller [:justdave]]

Attachment: Patch v2

doh!  that's what I get for copy/pasting the first one. :)

Comment 5

[Dave Miller [:justdave]]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.232; previous revision: 1.231
done