Closed Bug 204008 Opened 17 years ago Closed 17 years ago

checksetup.pl doesn't set correct permissions on js/ directory

Categories

(Bugzilla :: Installation & Upgrading, defect)

2.17.4
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: justdave, Assigned: justdave)

Details

Attachments

(1 file, 1 obsolete file)

checksetup.pl doesn't set correct permissions on js/ directory

Just cvs updated a 2.17.1 to 2.17.4 and picked up the js directory, which
checked out with owner-only privs.  Running checksetup.pl did not fix the
directory or its contents to be readable by the webserver.
Attached patch Patch (obsolete) — Splinter Review
Attachment #122171 - Flags: review?(zach)
-> me
Assignee: zach → justdave
Comment on attachment 122171 [details] [diff] [review]
Patch

>@@ -1183,6 +1184,7 @@
>     fixPerms('Bugzilla', $<, $gid, 022, 1);
>     fixPerms('template', $<, $gid, 022, 1);
>     fixPerms('css', $<, $gid, 022, 1);
>+    fixPerms('js', $<, $webservergid, 022, 1);

$webservergid doesn't exist here because the user didn't set webservergroup. I
think you mean $gid instead (in the second block of the patch)?
Attachment #122171 - Flags: review?(zach) → review-
Attached patch Patch v2Splinter Review
doh!  that's what I get for copy/pasting the first one. :)
Attachment #122171 - Attachment is obsolete: true
Attachment #122173 - Flags: review+
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.232; previous revision: 1.231
done
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: approval+
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.