2040125 - fast-path to skip proxy resolution missed MOZ_ENABLE_LIBPROXY case

Status: RESOLVED FIXED

(Core :: Networking: Proxy, defect, P3)

Description

[Christoph Moench-Tegeder]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:151.0) Gecko/20100101 Firefox/151.0

Steps to reproduce:

In bmo #2028356 a "fast-path to skip proxy resolution[...]" was added, but the required method GetSystemProxyDirect() was not added for libproxy-enabled builds (all other cases - general Unix without libproxy, OSX, Windows - got that function).

This makes a "--enable-libproxy" build (MOZ_ENABLE_LIBPROXY) fail at startup, as the symbol for nsUnixSystemProxySettings::GetSystemProxyDirect() does not resolve.

I have a patch to add GetSystemProxyDirect() to the MOZ_ENABLE_LIBPROXY case - it's trivial, as we cannot know what libproxy will return for a specific URL, thus the fast-path does not apply and we can just return "false".

Comment 1

[Christoph Moench-Tegeder]

Attachment: Bug 2040125 - add GetSystemProxyDirect() to libproxy path r=kershaw,valentin,#necko-reviewers

In bmo #2028356 a "fast-path to skip proxy resolution[...]" was added,
but the required method GetSystemProxyDirect() was not added for
libproxy-enabled builds (all other cases - general Unix without
libproxy, OSX, Windows - got that function).

This makes a "--enable-libproxy" build (MOZ_ENABLE_LIBPROXY) fail at
startup, as the symbol for nsUnixSystemProxySettings::GetSystemProxyDirect()
does not resolve.

This adds GetSystemProxyDirect() to the MOZ_ENABLE_LIBPROXY case - it's
trivial, as we cannot know what libproxy will return for a specific URL,
thus the fast-path does not apply and we can just return "false".

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, but is not confident enough to move the bug to that component.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2028356

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c4548a6d9281
https://hg.mozilla.org/integration/autoland/rev/6ad0c97b2327
add GetSystemProxyDirect() to libproxy path r=valentin,necko-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6ad0c97b2327

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:cmt, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Christoph Moench-Tegeder]

This only affects non-default build configurations, and anyone doing that can carry the patch for a while?
So I'd argue no uplift; but I'm not allowed to set the wontfix myself.