2040196 - Plumb the document's URL data through CSS.supports()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

With plumbing disabled_domains_pref should just work.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 2040196 - Refactor Servo_CSSSupports to take a params struct. r?#firefox-style-system-reviewers

Replace the three boolean parameters (ua_origin, chrome_sheet, quirks)
with a CssSupportsFlags struct of three small enums. This makes call
sites self-documenting and avoids the easy-to-misorder bool triplet.

Pure refactor: each call site preserves its prior semantics.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 2040196 - Plumb the document's URL data through CSS.supports(). r?#firefox-style-system-reviewers

Thus it's properly gated by disabled_domains_pref.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 2040196 - Use CSS.supports in the proper window context rather than the devtools sandbox in walker-search.js. r?#devtools-reviewers

This is the same manner [1] what we do in page-style.js.

[1] https://searchfox.org/firefox-main/rev/ca47ec6bb1f3e46a384cd1ebb11c5996cceef90f/devtools/server/actors/page-style.js#137-139

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 2040196 - Refactor Servo_CSSSupports to take a flags struct. r?#firefox-style-system-reviewers

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 2040196 - Plumb the document's URL data through CSS.supports(). r?#firefox-style-system-reviewers

Thus it's properly gated by disabled_domains_pref.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/487bc3a74c64
https://hg.mozilla.org/integration/autoland/rev/6a125cf77b6e
Use CSS.supports in the proper window context rather than the devtools sandbox in walker-search.js. r=devtools-reviewers,nchevobbe
https://github.com/mozilla-firefox/firefox/commit/9be32b42ea3d
https://hg.mozilla.org/integration/autoland/rev/bf8dc3719053
Refactor Servo_CSSSupports to take a params struct. r=firefox-style-system-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/46c9ded44c8b
https://hg.mozilla.org/integration/autoland/rev/69b64c31f956
Plumb the document's URL data through CSS.supports(). r=firefox-style-system-reviewers,layout-reviewers,emilio

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6a125cf77b6e
https://hg.mozilla.org/mozilla-central/rev/bf8dc3719053
https://hg.mozilla.org/mozilla-central/rev/69b64c31f956