2040347 - Transactions could be dropped when HappyEyeballsConnectionAttempt::Abandon is called

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Kershaw Chang [:kershaw]]

When two concurrent requests each enter a Happy Eyeballs 0-RTT race, ZeroRttHandle::Do0RTT removes both real transactions from the connection manager’s pending queue via LockInRealTxnFromPendingQueue. If one race wins and calls MakeAllDontReuseExcept() → CloseAllConnectionAttempts(), the other HappyEyeballsConnectionAttempt’s Abandon() is triggered. At that point, the transaction is neither in the pending queue nor attached to any connection, and Abandon() neither closes nor re-queues it. As a result, the channel waits indefinitely and eventually times out with NS_BINDING_ABORTED.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 2040347 - Replace ZeroRttHandle::mWinner raw pointer with RefPtr, r=#necko

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 2040347 - Re-queue real transaction when 0-RTT HappyEyeballsConnectionAttempt is externally abandoned, r=#necko

Depends on D301058

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 2040347 - Add test, r=#necko

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 2040347 - Add some debug assertions to check if we handle the transaction properly, r=#necko

Depends on D301104

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/635469e39b87
https://hg.mozilla.org/integration/autoland/rev/272735c31817
Replace ZeroRttHandle::mWinner raw pointer with RefPtr, r=mxinden
https://github.com/mozilla-firefox/firefox/commit/88aa23cb6825
https://hg.mozilla.org/integration/autoland/rev/07a7081f123d
Re-queue real transaction when 0-RTT HappyEyeballsConnectionAttempt is externally abandoned, r=necko-reviewers,jesup
https://github.com/mozilla-firefox/firefox/commit/435389ed9653
https://hg.mozilla.org/integration/autoland/rev/6aa8326b08e6
Add test, r=necko-reviewers,jesup
https://github.com/mozilla-firefox/firefox/commit/01181d6f0c5f
https://hg.mozilla.org/integration/autoland/rev/5c4a6a558418
Add some debug assertions to check if we handle the transaction properly, r=necko-reviewers,jesup,mxinden

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/272735c31817
https://hg.mozilla.org/mozilla-central/rev/07a7081f123d
https://hg.mozilla.org/mozilla-central/rev/6aa8326b08e6
https://hg.mozilla.org/mozilla-central/rev/5c4a6a558418