2040360 - Settings-redesign: Custom tracking protection cookies drop down missing "block" context

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Manuel Bucher [:manuel]]

Attachment: new-settings.png

The drop down menu of cookies is missing the verb for all the "Block ..." items.

• Allow all cookies
• Block cross-site cookies
• Isolate cross-site cookies
• Block cookies from unvisited websites
• Block all cross-site cookies (may cause websites to break)
• Block all cookies (will cause websites to break)

This is reusing the strings from the old preference page. However the "Block ..." was implied by the context there. However, that changed a bit with Bug 1974389, where "Cross-site trackers and isolate cross-site cookies" got updated into "Isolate cross-site cookies".

Reported by flod on slack

Comment 1

[Manuel Bucher [:manuel]]

Attachment: old-settings.png

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 2040360 - Custom tracking protection cookies drop down missing "block" context - r=mkennedy!,bolsson!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eb450920fd5a
https://hg.mozilla.org/integration/autoland/rev/5d994b0c0b73
Custom tracking protection cookies drop down missing "block" context - r=bolsson,fluent-reviewers,mkennedy

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/5d994b0c0b73

Comment 5

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 2040360 - Custom tracking protection cookies drop down missing "block" context -

Original Revision: https://phabricator.services.mozilla.com/D301139

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Confusing strings in ETP Custom Cookies dropdown menu
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Lag in localization may show unlocalized strings.
• String changes made/needed?: Options in ETP Custom Cookies dropdown menu are updated by this patch.
• Is Android affected?: no

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/dd0c838b4cde
https://hg.mozilla.org/releases/mozilla-beta/rev/e6df39c07766