2040437 - Follow-ups to bug 2028605 to tweak the Report Broken Site redesign

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, enhancement, P3)

Description

[Thomas Wisniewski [:twisniewski]]

We have decided on these changes so far:

• fix the awkward bugs likely introduced by the panelmultiview a11y code for keyboard tabbing, where it automatically defocuses elements, including:
  • how pressing the reset/esc on the url bar does not actually reset the first time.
  • the favicon and options on the first slide also not disabling on defocus.
  • the comment box defocusing on mouse-move when "something else" is picked.
• no longer randomize the options on the first panel ("site is deceptive" and "something else" should be last).
• add some kind of text above the URL to make it clear what it is (perhaps "URL of site being reported").
• remove the auto-sizing behavior of the panels.
• fix the "invalid" tooltip on the comment-box when it is invalid (have the tooltip show the error text instead).

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::CSS Parsing and Computation' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - optimize away a :has selector in the panelview code added for the report broken site UX update in bug 2028605; r?dao,mossop

Comment 3

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 1: do not autosize the report broken panel, just do what we did before the redesign; r?mossop

Comment 4

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 2: ignore the next mouse move after we deliberately focus on an invalid input; r?mossop

Comment 5

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 3: remove no-longer-wanted code to randomize the reason selector options on Report Broken Site, and re-order the default choices a little; r?mossop

Comment 6

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 4: use a better tooltip text than 'invalid' for the Report Broken Site comment box; r?mossop

Comment 7

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 5: add more space between send-more-info and report-preview on the Report Broken Site details view, and hide their superfluous border on Nova; r?mossop

Comment 8

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 6: add a label above each URL input on Report Broken Site; r?mossop

Comment 9

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 7: fix progression-disabling while changing the URLs on Report Broken Site; r?mossop

Comment 10

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 8: improve tab-key handling on panels to account for the activeElement being in a shadowRoot so tree-walking doesn't begin with the first navigable element; r?mossop

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c1be7be93810
https://hg.mozilla.org/integration/autoland/rev/173959eb140b
part 1: do not autosize the report broken panel, just do what we did before the redesign; r=mossop
https://github.com/mozilla-firefox/firefox/commit/7b36e78e177d
https://hg.mozilla.org/integration/autoland/rev/557b30e0673f
part 2: ignore the next mouse move after we deliberately focus on an invalid input; r=mossop
https://github.com/mozilla-firefox/firefox/commit/c46aa2c0c46c
https://hg.mozilla.org/integration/autoland/rev/8ffa101cf449
part 3: remove no-longer-wanted code to randomize the reason selector options on Report Broken Site, and re-order the default choices a little; r=mossop
https://github.com/mozilla-firefox/firefox/commit/74b814b4fb3c
https://hg.mozilla.org/integration/autoland/rev/045bb7a6c90c
part 4: use a better tooltip text than 'invalid' for the Report Broken Site comment box; r=mossop
https://github.com/mozilla-firefox/firefox/commit/afdce3a83119
https://hg.mozilla.org/integration/autoland/rev/82455b7b6d87
part 5: add more space between send-more-info and report-preview on the Report Broken Site details view, and hide their superfluous border on Nova; r=mossop
https://github.com/mozilla-firefox/firefox/commit/e7de0706d5be
https://hg.mozilla.org/integration/autoland/rev/ca0178e31907
part 6: add a label above each URL input on Report Broken Site; r=mossop,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/c89c09ab3fe1
https://hg.mozilla.org/integration/autoland/rev/15ecb2117bee
part 7: fix progression-disabling while changing the URLs on Report Broken Site; r=mossop
https://github.com/mozilla-firefox/firefox/commit/e8339bcc4ee5
https://hg.mozilla.org/integration/autoland/rev/70063ed778e1
part 8: improve tab-key handling on panels to account for the activeElement being in a shadowRoot so tree-walking doesn't begin with the first navigable element; r=mossop

Comment 12

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/173959eb140b
https://hg.mozilla.org/mozilla-central/rev/557b30e0673f
https://hg.mozilla.org/mozilla-central/rev/8ffa101cf449
https://hg.mozilla.org/mozilla-central/rev/045bb7a6c90c
https://hg.mozilla.org/mozilla-central/rev/82455b7b6d87
https://hg.mozilla.org/mozilla-central/rev/ca0178e31907
https://hg.mozilla.org/mozilla-central/rev/15ecb2117bee
https://hg.mozilla.org/mozilla-central/rev/70063ed778e1

Comment 13

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 1: do not autosize the report broken panel, just do what we did before the redesign;

Original Revision: https://phabricator.services.mozilla.com/D302067

Comment 14

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 2: ignore the next mouse move after we deliberately focus on an invalid input;

Original Revision: https://phabricator.services.mozilla.com/D302068

Comment 15

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 3: remove no-longer-wanted code to randomize the reason selector options on Report Broken Site, and re-order the default choices a little;

Original Revision: https://phabricator.services.mozilla.com/D302069

Comment 16

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 4: use a better tooltip text than 'invalid' for the Report Broken Site comment box;

Original Revision: https://phabricator.services.mozilla.com/D302070

Comment 17

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 5: add more space between send-more-info and report-preview on the Report Broken Site details view, and hide their superfluous border on Nova;

Original Revision: https://phabricator.services.mozilla.com/D302071

Comment 18

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 6: add a label above each URL input on Report Broken Site;

Original Revision: https://phabricator.services.mozilla.com/D302072

Comment 19

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 7: fix progression-disabling while changing the URLs on Report Broken Site;

Original Revision: https://phabricator.services.mozilla.com/D302073

Comment 20

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2040437 - part 8: improve tab-key handling on panels to account for the activeElement being in a shadowRoot so tree-walking doesn't begin with the first navigable element;

Original Revision: https://phabricator.services.mozilla.com/D302074

Comment 21

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5eb60dca72ea
https://hg.mozilla.org/releases/mozilla-beta/rev/53f4eb81b27d
https://github.com/mozilla-firefox/firefox/commit/84b94582e369
https://hg.mozilla.org/releases/mozilla-beta/rev/9a51cddbddb8
https://github.com/mozilla-firefox/firefox/commit/7668eb927d62
https://hg.mozilla.org/releases/mozilla-beta/rev/07301a0bb9ed
https://github.com/mozilla-firefox/firefox/commit/24685772bb68
https://hg.mozilla.org/releases/mozilla-beta/rev/1fe70aded84d
https://github.com/mozilla-firefox/firefox/commit/ded313a58f68
https://hg.mozilla.org/releases/mozilla-beta/rev/756d4ee987f1
https://github.com/mozilla-firefox/firefox/commit/cc4331d7309c
https://hg.mozilla.org/releases/mozilla-beta/rev/9ae8183e3bdb
https://github.com/mozilla-firefox/firefox/commit/c8e295102c71
https://hg.mozilla.org/releases/mozilla-beta/rev/1e72ae431716
https://github.com/mozilla-firefox/firefox/commit/44813dcc4337
https://hg.mozilla.org/releases/mozilla-beta/rev/a2e8eba1013b

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Reverting part 6 from Beta due to the new string it added. The rest of the patches are still there.

Comment 23

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8e562ee45901
https://hg.mozilla.org/releases/mozilla-beta/rev/cafa5e658f00