2040498 - Clicking "delete group" on group context menu in tab groups list doesn't dismiss toolbar panel

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser: Tab Groups, defect, P3)

Description

[Stephen Thompson [:sthompson]]

With browser.tabs.groups.alternateMenu enabled, restart Firefox, right-click the toolbar, choose to customize the toolbar, and add the Tab Groups toolbar button to the nav bar.

Create a tab group. Click the Tab Groups toolbar button, then right-click the tab group in that list. It opens a tab group context menu. Choose the "delete group" context menu entry.

This correctly deletes the tab group (and for a saved group, "delete group" will correctly forget the group). However, the tab groups list stays open and continues displaying the tab group that was just removed.

The Tab Groups toolbar button panel should be closed when taking any action. The "open group" and "move group" options in the context menu already seem to dismiss the panel, but the "delete group" options in the open group and saved group context menus do not dismiss the menu.

Comment 1

[Fede]

Attachment: Bug 2040498 - Dismiss the tab groups list panel when a group is deleted from the context menu r?#tabbrowser-reviewers

The tab-groups-list element only populated its state when connected,
so deleting a group from the row context menu left a stale row in the
list until the panel was reopened. Observe
browser-tabgroup-removed-from-dom and
sessionstore-saved-tab-groups-changed (the same notifications the
GroupsList-based menu uses) to repopulate in place. The observers are
registered weakly because the app menu instance stays connected for
the lifetime of the window.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1acd09a997b3
https://hg.mozilla.org/integration/autoland/rev/d888cbc3972d
Dismiss the tab groups list panel when a group is deleted from the context menu r=tabbrowser-reviewers,jswinarton,sthompson

Comment 3

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/d888cbc3972d