Closed
Bug 2040519
Opened 1 month ago
Closed 16 days ago
Add logic to feed data to display correct translated strings
Categories
(Firefox :: New Tab Page, task)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | verified |
People
(Reporter: maxx, Assigned: nina-py)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
When rendering feed data, there are two points that will require logic to detect/print the correct Fluent strings:
- Stage
- If group, print localized Group A|B|...L stage name
- If not "Group Stage", print localized stage name
- Status
- Catch and print these (l10n) statuses
| Assignee | ||
Updated•1 month ago
|
Assignee: nobody → npypchenko
Status: NEW → ASSIGNED
| Reporter | ||
Comment 1•26 days ago
|
||
I think these may already be completed:
- Match status See SportsMatchRow.jsx#11-23,173-199
- Group Stages See components/Widgets/SportsWidget/stageLabels.mjs
Nina - What parts of this are still incomplete?
| Reporter | ||
Updated•26 days ago
|
Blocks: live-tournament-trainhop
| Assignee | ||
Comment 2•26 days ago
|
||
Updated•24 days ago
|
Attachment #9592808 -
Attachment description: WIP: Bug 2040519 - Sports widget: Add logic to feed data to display correct translated strings → Bug 2040519 - Sports widget: Add logic to feed data to display correct translated strings r=#home-newtab-reviewers!
| Reporter | ||
Updated•16 days ago
|
Pushed by sdowne@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/71d64db5f10b
https://hg.mozilla.org/integration/autoland/rev/8b10842e34d4
Sports widget: Add logic to feed data to display correct translated strings r=thecount,maxx
Comment 4•16 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 16 days ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Comment 5•12 days ago
|
||
Verified as fixed following the steps from https://phabricator.services.mozilla.com/D304294 on Windows 11 x64, macOS 14 and Ubuntu 24.
Tested on Firefox 153.0a1 and Firefox 152.0 with train hop addon v 153.5.20260615.213953.
Updated•12 days ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•