2040603 - Show assembler offsets in IONFLAGS=codegen output for arm32 and riscv64

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Julian Seward [:jseward]]

IONFLAGS=codegen output currently shows assembler offsets on x86_32, x86_64 and
arm64. This facilitates debugging of wasm::TrapSiteDesc and wasm::StackMap
bugs.

This patch pair adds offset printing for arm32 and riscv64.

See also bug 2024938.

Comment 1

[Julian Seward [:jseward]]

Attachment: Bug 2040603 - part 1: Show assembler offsets in IONFLAGS=codegen output for arm32. r=nbp.

For IONFLAGS=codegen, on arm32, best-effort printing of assembler buffer
offsets is now done, with the format (as per other architectures) "%06x ".

Comment 2

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:jseward, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/329d6f4d364e
https://hg.mozilla.org/integration/autoland/rev/b80f86505ce5
part 1: Show assembler offsets in IONFLAGS=codegen output for arm32.  r=nbp.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b80f86505ce5