Closed Bug 2040637 Opened 13 days ago Closed 9 days ago

Perma TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_ssl_token_cache_persist.js | test_ssl_token_cache_written_on_idle_daily | when Gecko 153 switches to Beta on 2026-06-26

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
153 Branch
Tracking Flags:
Tracking Status
thunderbird_esr140 --- unaffected
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox151 --- unaffected
firefox152 --- fixed
firefox153 + fixed

People

(Reporter: asilaghi, Assigned: leggert)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [stockwell unknown][stockwell needswork:owner])

Attachments

(2 files)

Bug 2040637 - Reconcile ssl_tokens_cache_persistence pref with user.js r?valentin,kershaw,#necko-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 2040637 - Reconcile ssl_tokens_cache_persistence pref with user.js
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Summary: Perma | netwerk/test/unit/test_ssl_token_cache_persist.js | test_ssl_token_cache_written_on_idle_daily | when Gecko 153 switches to Beta on 2026-05-29 → Perma | TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_ssl_token_cache_persist.js | test_ssl_token_cache_written_on_idle_daily | when Gecko 153 switches to Beta on 2026-05-29
tracking-firefox153: ? → +
Summary: Perma | TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_ssl_token_cache_persist.js | test_ssl_token_cache_written_on_idle_daily | when Gecko 153 switches to Beta on 2026-05-29 → Perma TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_ssl_token_cache_persist.js | test_ssl_token_cache_written_on_idle_daily | when Gecko 153 switches to Beta on 2026-05-29

Init() runs before user prefs are applied, so the persistence pref may be
false even when later set to true. Always registering profile-after-change
lets the handler enable persistence and register write observers on demand.

Assignee: nobody → leggert
Status: NEW → ASSIGNED
Attachment #9587939 - Attachment description: Bug 2040637 - Register profile-after-change unconditionally in SSLTokensCache::Init. r=valentin,kershaw,#necko-reviewers → Bug 2040637 - Reconcile ssl_tokens_cache_persistence pref with user.js r?valentin,kershaw,#necko-reviewers
See Also: → 2034342
Flags: needinfo?(leggert)

The patch is working in today's beta simulation.

Reverted this because it was causing build bustages.

Sorry about that, I forgot to write down on the bug that I encountered these bustages also when I tried to import it on today's central as beta simulation. Also, I tried to change test_ssl_token_cache_persist_disabled.js from xpcshell.tom into test_ssl_token_cache_persist.js to see if it's work but I didn't had any luck so I made the simulation without your patch.

Flags: needinfo?(leggert)
Summary: Perma TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_ssl_token_cache_persist.js | test_ssl_token_cache_written_on_idle_daily | when Gecko 153 switches to Beta on 2026-05-29 → Perma TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_ssl_token_cache_persist.js | test_ssl_token_cache_written_on_idle_daily | when Gecko 153 switches to Beta on 2026-06-26
Pushed by leggert@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b642b7f69c0f https://hg.mozilla.org/integration/autoland/rev/c4a8fdc82fa9 Reconcile ssl_tokens_cache_persistence pref with user.js r=kershaw,necko-reviewers
Pushed by nfay@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3dba5504dc05 https://hg.mozilla.org/integration/autoland/rev/f03bf8e00813 Revert "Bug 2040637 - Reconcile ssl_tokens_cache_persistence pref with user.js r=kershaw,necko-reviewers" for causing xpcshell failure @ test_ssl_token_cache_persist_disabled.js

Backed out for causing xpcshell failure @ test_ssl_token_cache_persist_disabled.js

Backout link

Push with failures

Failure log

Pushed by leggert@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/208dcf1f587a https://hg.mozilla.org/integration/autoland/rev/99aadd861bb3 Reconcile ssl_tokens_cache_persistence pref with user.js r=kershaw,necko-reviewers

https://hg.mozilla.org/mozilla-central/rev/99aadd861bb3

Status: ASSIGNED → RESOLVED
Closed: 9 days ago
status-firefox153: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch

Does this need a beta uplift to fix the issue?

Flags: needinfo?(leggert)

Appears that way, yes.

Flags: needinfo?(leggert)
Flags: in-testsuite+

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Fixes perma test failure.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: TLS token persistence is pref'ed to early-beta.
  • String changes made/needed?: No
  • Is Android affected?: yes
Attachment #9592009 - Flags: approval-mozilla-beta?

SSLTokensCache::Init() runs before user prefs (user.js) are applied, so it
sees the compile-time default for network.ssl_tokens_cache_persistence.

Init() now registers the profile-after-change observer unconditionally
(before the pref check). The handler reconciles persistence state with
the actual pref value: enabling write observers and the shutdown blocker
if the pref is now true (Bug 2040637), or tearing them down if Init()
set them up but the pref is now false (Bug 2034342).

Original Revision: https://phabricator.services.mozilla.com/D301474

Flags: needinfo?(leggert)
Attachment #9592009 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: